[PR #868] [MERGED] Make path separators in UI more consistent #171

New Issue

claunia · 2026-01-29T19:06:43Z

claunia commented

2026-01-29 19:06:43 +00:00

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/868
Author: @CookiePLMonster
Created: 9/19/2020
Status: ✅ Merged
Merged: 9/20/2020
Merged by: @stenzek

Base: master ← Head: separator-consistency

📝 Commits (1)

92d0dab Make path separators in UI more consistent

📊 Changes

10 files changed (+62 additions, -54 deletions)

View changed files

📝 src/common/file_system.h (+2 -0)
📝 src/core/host_interface.cpp (+5 -5)
📝 src/core/settings.cpp (+6 -4)
📝 src/duckstation-libretro/libretro_host_interface.cpp (+4 -5)
📝 src/duckstation-qt/consolesettingswidget.cpp (+7 -4)
📝 src/duckstation-qt/gamepropertiesdialog.cpp (+6 -4)
📝 src/duckstation-qt/memorycardeditordialog.cpp (+1 -1)
📝 src/frontend-common/common_host_interface.cpp (+16 -16)
📝 src/frontend-common/postprocessing_chain.cpp (+3 -3)
📝 src/updater/updater.cpp (+12 -12)

📄 Description

Before that, BIOS and memory card selection still used a / separator on Windows, and various imgui popups would mix \ and / in their messages.

Now separators are consistent, and I replaced runtime %c formatters with compile time string literal concatenation, as there is really no reason for separators to be concatenated on runtime.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/868 **Author:** [@CookiePLMonster](https://github.com/CookiePLMonster) **Created:** 9/19/2020 **Status:** ✅ Merged **Merged:** 9/20/2020 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `separator-consistency` --- ### 📝 Commits (1) - [`92d0dab`](https://github.com/stenzek/duckstation/commit/92d0dabf549f19c04661ae71a283a7fec2d85161) Make path separators in UI more consistent ### 📊 Changes **10 files changed** (+62 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `src/common/file_system.h` (+2 -0) 📝 `src/core/host_interface.cpp` (+5 -5) 📝 `src/core/settings.cpp` (+6 -4) 📝 `src/duckstation-libretro/libretro_host_interface.cpp` (+4 -5) 📝 `src/duckstation-qt/consolesettingswidget.cpp` (+7 -4) 📝 `src/duckstation-qt/gamepropertiesdialog.cpp` (+6 -4) 📝 `src/duckstation-qt/memorycardeditordialog.cpp` (+1 -1) 📝 `src/frontend-common/common_host_interface.cpp` (+16 -16) 📝 `src/frontend-common/postprocessing_chain.cpp` (+3 -3) 📝 `src/updater/updater.cpp` (+12 -12) </details> ### 📄 Description Before that, BIOS and memory card selection still used a `/` separator on Windows, and various imgui popups would mix `\` and `/` in their messages. Now separators are consistent, and I replaced runtime `%c` formatters with compile time string literal concatenation, as there is really no reason for separators to be concatenated on runtime. ![image](https://user-images.githubusercontent.com/7947461/93689238-d6120900-facc-11ea-8392-e0b76f99e633.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 19:06:43 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/duckstation#171