[PR #931] [MERGED] Add 16:10 Aspect Ratio Option #219

New Issue

claunia · 2026-01-29T19:06:55Z

claunia commented

2026-01-29 19:06:55 +00:00

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/931
Author: @mirrornoir
Created: 10/5/2020
Status: ✅ Merged
Merged: 10/7/2020
Merged by: @stenzek

Base: master ← Head: patch-3

📝 Commits (2)

a879426 Add 16:10 aspect ratio opton
9f7ff60 Add 16:10 deffinition

📊 Changes

2 files changed (+5 additions, -4 deletions)

View changed files

📝 src/core/settings.cpp (+4 -4)
📝 src/core/types.h (+1 -0)

📄 Description

This time I didn't forget to declare it in types.h heh. This change was mostly so I could learn how to make a PR that changes two files, if this PR is unnecessary to due to proposed custom aspect ratio feature as mentioned here https://github.com/stenzek/duckstation/issues/362#issuecomment-686953114, then feel free to drop it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/931 **Author:** [@mirrornoir](https://github.com/mirrornoir) **Created:** 10/5/2020 **Status:** ✅ Merged **Merged:** 10/7/2020 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `patch-3` --- ### 📝 Commits (2) - [`a879426`](https://github.com/stenzek/duckstation/commit/a879426d55fba3ed3ad9cbbc8fccc2ade823507d) Add 16:10 aspect ratio opton - [`9f7ff60`](https://github.com/stenzek/duckstation/commit/9f7ff60279b60eed6b8033c834ea9c468ba73256) Add 16:10 deffinition ### 📊 Changes **2 files changed** (+5 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/core/settings.cpp` (+4 -4) 📝 `src/core/types.h` (+1 -0) </details> ### 📄 Description This time I didn't forget to declare it in `types.h` heh. This change was mostly so I could learn how to make a PR that changes two files, if this PR is unnecessary to due to proposed custom aspect ratio feature as mentioned here https://github.com/stenzek/duckstation/issues/362#issuecomment-686953114, then feel free to drop it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 19:06:55 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/duckstation#219