starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #989] [MERGED] CommonHostInterface: Activate hotkeys on press instead of release #249

New Issue
Open
opened 2026-01-29 19:07:04 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:07:04 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/989
Author: @ggrtk
Created: 10/20/2020
Status: ✅ Merged
Merged: 10/20/2020
Merged by: @stenzek

Base: master ← Head: hotkeys-pressed

📝 Commits (1)

  • 9b8fbeb CommonHostInterface: Activate hotkeys on press instead of release

📊 Changes

1 file changed (+25 additions, -25 deletions)

View changed files

📝 src/frontend-common/common_host_interface.cpp (+25 -25)

📄 Description

The volume up/down hotkeys were activating on press while the rest of the hotkeys were activating on release. This standardizes hotkeys to activate on press rather than release. Should also resolve the first part of #923 since closing dialogs with Esc triggers on a key down, but the hotkey bound to Esc would then be activated on the key up.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/989 **Author:** [@ggrtk](https://github.com/ggrtk) **Created:** 10/20/2020 **Status:** ✅ Merged **Merged:** 10/20/2020 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `hotkeys-pressed` --- ### 📝 Commits (1) - [`9b8fbeb`](https://github.com/stenzek/duckstation/commit/9b8fbeb08768f538d87958bd4695768942ff588b) CommonHostInterface: Activate hotkeys on press instead of release ### 📊 Changes **1 file changed** (+25 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `src/frontend-common/common_host_interface.cpp` (+25 -25) </details> ### 📄 Description The volume up/down hotkeys were activating on press while the rest of the hotkeys were activating on release. This standardizes hotkeys to activate on press rather than release. Should also resolve the first part of #923 since closing dialogs with Esc triggers on a key down, but the hotkey bound to Esc would then be activated on the key up. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:07:04 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#249
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?