[PR #1045] AnalogController: Implement legacy rumble method #287

New Issue

claunia · 2026-01-29T19:07:14Z

claunia commented

2026-01-29 19:07:14 +00:00

Original Pull Request: https://github.com/stenzek/duckstation/pull/1045

State: closed
Merged: Yes

Doesn't seem strictly necessary to save m_legacy_rumble_unlocked to state since it's only toggled during pad read sequences. I think the worst that could happen is missing or getting an extra frame of rumble on load state if the state was created very precisely in the middle of transferring the two motor bytes, so it's probably safe to wait for the next save state bump for saving the variable to state.

**Original Pull Request:** https://github.com/stenzek/duckstation/pull/1045 **State:** closed **Merged:** Yes --- Doesn't seem strictly necessary to save `m_legacy_rumble_unlocked` to state since it's only toggled during pad read sequences. I think the worst that could happen is missing or getting an extra frame of rumble on load state if the state was created very precisely in the middle of transferring the two motor bytes, so it's probably safe to wait for the next save state bump for saving the variable to state.

claunia added the pull-request label 2026-01-29 19:07:14 +00:00

claunia closed this issue

2026-01-29 19:07:14 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/duckstation#287