starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #565] [MERGED] timestamp: Correct duplicate conditionals #32

New Issue
Open
opened 2026-01-29 19:06:08 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:06:08 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/565
Author: @lioncash
Created: 6/23/2020
Status: ✅ Merged
Merged: 6/23/2020
Merged by: @stenzek

Base: master ← Head: stamp

📝 Commits (2)

  • 987b11a timestamp: Implement operator!= in terms of operator==
  • 4c82705 timestamp: Correct duplicate conditionals

📊 Changes

1 file changed (+17 additions, -21 deletions)

View changed files

📝 src/common/timestamp.cpp (+17 -21)

📄 Description

Previously, the milliseconds field wasn't being used in comparisons on Windows. Instead, the hour field was being checked against twice

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/565 **Author:** [@lioncash](https://github.com/lioncash) **Created:** 6/23/2020 **Status:** ✅ Merged **Merged:** 6/23/2020 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `stamp` --- ### 📝 Commits (2) - [`987b11a`](https://github.com/stenzek/duckstation/commit/987b11a1d295c28f59e350553faedbae55d7fa3a) timestamp: Implement operator!= in terms of operator== - [`4c82705`](https://github.com/stenzek/duckstation/commit/4c82705e34651d35e8cf5e303f3ebbc5a75f6670) timestamp: Correct duplicate conditionals ### 📊 Changes **1 file changed** (+17 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `src/common/timestamp.cpp` (+17 -21) </details> ### 📄 Description Previously, the milliseconds field wasn't being used in comparisons on Windows. Instead, the hour field was being checked against twice --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:06:08 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#32
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?