starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #1146] [MERGED] XInput: Fix mapping triggers to axes #345

New Issue
Open
opened 2026-01-29 19:07:29 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:07:29 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/1146
Author: @CookiePLMonster
Created: 12/4/2020
Status: ✅ Merged
Merged: 12/5/2020
Merged by: @stenzek

Base: master ← Head: xinput-axis-fix

📝 Commits (1)

  • 39768ed XInput: Fix mapping triggers to axes

📊 Changes

1 file changed (+9 additions, -1 deletions)

View changed files

📝 src/frontend-common/xinput_controller_interface.cpp (+9 -1)

📄 Description

For #1078 I had to rescale NeGcon buttons to accept inputs from -1..1 instead of 0..1, so in the case of triggers inputs had to be expanded appropriately. I did this for SDL but forgot to do it for XInput.

Fixes #1136

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/1146 **Author:** [@CookiePLMonster](https://github.com/CookiePLMonster) **Created:** 12/4/2020 **Status:** ✅ Merged **Merged:** 12/5/2020 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `xinput-axis-fix` --- ### 📝 Commits (1) - [`39768ed`](https://github.com/stenzek/duckstation/commit/39768edd746bcc88f561f780958e6d5fe23d53b4) XInput: Fix mapping triggers to axes ### 📊 Changes **1 file changed** (+9 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/frontend-common/xinput_controller_interface.cpp` (+9 -1) </details> ### 📄 Description For #1078 I had to rescale NeGcon buttons to accept inputs from `-1..1` instead of `0..1`, so in the case of triggers inputs had to be expanded appropriately. I did this for SDL but forgot to do it for XInput. Fixes #1136 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:07:30 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#345
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?