starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #1285] [MERGED] Memory Card Editor fixes #422

New Issue
Open
opened 2026-01-29 19:07:50 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:07:50 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/1285
Author: @CookiePLMonster
Created: 12/22/2020
Status: ✅ Merged
Merged: 12/22/2020
Merged by: @stenzek

Base: master ← Head: memcard-slashes-fix

📝 Commits (2)

  • bb528fb Fix inconsistent forward/backward slashes in Memcard Editor
  • 51eb494 Memcard Editor: Fix relative shared paths not opening in Memcard Editor by default

📊 Changes

3 files changed (+26 additions, -16 deletions)

View changed files

📝 src/duckstation-qt/memorycardeditordialog.cpp (+8 -7)
📝 src/duckstation-qt/memorycardsettingswidget.cpp (+4 -3)
📝 src/duckstation-qt/qthostinterface.cpp (+14 -6)

📄 Description

Fixes two issues:

  1. Forward/backward slashes were inconsistent, leading to mismatches in the combobox. Now native separators are used consistently.
  2. Fixes a bug where relative path shared memcard would not be found in the combobox, causing a false positive "could not find the memory card" error.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/1285 **Author:** [@CookiePLMonster](https://github.com/CookiePLMonster) **Created:** 12/22/2020 **Status:** ✅ Merged **Merged:** 12/22/2020 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `memcard-slashes-fix` --- ### 📝 Commits (2) - [`bb528fb`](https://github.com/stenzek/duckstation/commit/bb528fb15cef8cade24fa60b01623b320844028b) Fix inconsistent forward/backward slashes in Memcard Editor - [`51eb494`](https://github.com/stenzek/duckstation/commit/51eb494340e601f494e78e8d46c7bd3bd3fc4f00) Memcard Editor: Fix relative shared paths not opening in Memcard Editor by default ### 📊 Changes **3 files changed** (+26 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src/duckstation-qt/memorycardeditordialog.cpp` (+8 -7) 📝 `src/duckstation-qt/memorycardsettingswidget.cpp` (+4 -3) 📝 `src/duckstation-qt/qthostinterface.cpp` (+14 -6) </details> ### 📄 Description Fixes two issues: 1. Forward/backward slashes were inconsistent, leading to mismatches in the combobox. Now native separators are used consistently. 2. Fixes a bug where relative path shared memcard would not be found in the combobox, causing a false positive "could not find the memory card" error. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:07:50 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#422
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?