[PR #1317] [MERGED] Changed debugger "Enter memory address" to accept hex only #440

New Issue

claunia · 2026-01-29T19:07:57Z

claunia commented

2026-01-29 19:07:57 +00:00

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/1317
Author: @PugsyMAME
Created: 12/26/2020
Status: ✅ Merged
Merged: 12/26/2020
Merged by: @stenzek

Base: master ← Head: master

📝 Commits (3)

a90a3d5 Changed debugger "Enter memory address" to accept hex only
398ae04 Translation updates for Debugger memory address change
7d11e19 Changed debugger "Enter memory address" to accept hex only

📊 Changes

7 files changed (+17 additions, -17 deletions)

View changed files

📝 src/duckstation-qt/cheatmanagerdialog.cpp (+1 -1)
📝 src/duckstation-qt/debuggerwindow.cpp (+3 -3)
📝 src/duckstation-qt/qtutils.cpp (+6 -6)
📝 src/duckstation-qt/qtutils.h (+2 -2)
📝 src/duckstation-qt/translations/duckstation-qt_fr.ts (+1 -1)
📝 src/duckstation-qt/translations/duckstation-qt_pt-br.ts (+2 -2)
📝 src/duckstation-qt/translations/duckstation-qt_zh-cn.ts (+2 -2)

📄 Description

UPDATE TO PR #1316
The "Enter memory address" prompt by default expects a decimal address unless it's preceded by 0x. Or it expects an number starting with 0 is an octal.
The disassembly address should be hexadecimal regardless as that is how it it displays the address.
Also changed it so that it changes any breakpoint or disassembly address entered to be divisible by 4 as there was an observed issue that would cause the disassembly addresses to get locked to a address that was not divisible by 4> Also setting a breakpoint address that is not divisible by 4 would never be pointless.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/1317 **Author:** [@PugsyMAME](https://github.com/PugsyMAME) **Created:** 12/26/2020 **Status:** ✅ Merged **Merged:** 12/26/2020 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`a90a3d5`](https://github.com/stenzek/duckstation/commit/a90a3d5bd8d401345804e1c9dc5355840e8fb05a) Changed debugger "Enter memory address" to accept hex only - [`398ae04`](https://github.com/stenzek/duckstation/commit/398ae044ed720fa2dfe3c9dfe73a3f3a2436b5c3) Translation updates for Debugger memory address change - [`7d11e19`](https://github.com/stenzek/duckstation/commit/7d11e191fbebbf519b596424ecfb6c4e685492cf) Changed debugger "Enter memory address" to accept hex only ### 📊 Changes **7 files changed** (+17 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `src/duckstation-qt/cheatmanagerdialog.cpp` (+1 -1) 📝 `src/duckstation-qt/debuggerwindow.cpp` (+3 -3) 📝 `src/duckstation-qt/qtutils.cpp` (+6 -6) 📝 `src/duckstation-qt/qtutils.h` (+2 -2) 📝 `src/duckstation-qt/translations/duckstation-qt_fr.ts` (+1 -1) 📝 `src/duckstation-qt/translations/duckstation-qt_pt-br.ts` (+2 -2) 📝 `src/duckstation-qt/translations/duckstation-qt_zh-cn.ts` (+2 -2) </details> ### 📄 Description UPDATE TO PR #1316 The "Enter memory address" prompt by default expects a decimal address unless it's preceded by 0x. Or it expects an number starting with 0 is an octal. The disassembly address should be hexadecimal regardless as that is how it it displays the address. Also changed it so that it changes any breakpoint or disassembly address entered to be divisible by 4 as there was an observed issue that would cause the disassembly addresses to get locked to a address that was not divisible by 4> Also setting a breakpoint address that is not divisible by 4 would never be pointless. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 19:07:57 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/duckstation#440