[PR #1328] [CLOSED] Hack: Shader Interface Block INI setting #452

Open
opened 2026-01-29 19:07:59 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/1328
Author: @KrossX
Created: 12/27/2020
Status: Closed

Base: masterHead: hack_interface_block


📝 Commits (1)

  • d95c8e0 Add INI setting to disable shader Interface Blocks from being used

📊 Changes

4 files changed (+6 additions, -1 deletions)

View changed files

📝 src/core/host_interface.cpp (+1 -0)
📝 src/core/settings.cpp (+2 -0)
📝 src/core/settings.h (+1 -0)
📝 src/core/shadergen.cpp (+2 -1)

📄 Description

As found in #1026, old Radeon OGL driver has issues with the qualifier used for SSAA and Interface Blocks. This PR adds an INI setting that allows to disable shader Interface Blocks from being used and avoid the bug.

Currently, I've been just making custom builds with the interface blocks disabled so I decided to try and make a setting for it. It's the least invasive way I found, although it exposes global settings to the shader generator. No UI settings either, too hacky for "advanced" even.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/1328 **Author:** [@KrossX](https://github.com/KrossX) **Created:** 12/27/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `hack_interface_block` --- ### 📝 Commits (1) - [`d95c8e0`](https://github.com/stenzek/duckstation/commit/d95c8e0fd0b9c451c428b55d679cefad5c7c7275) Add INI setting to disable shader Interface Blocks from being used ### 📊 Changes **4 files changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/core/host_interface.cpp` (+1 -0) 📝 `src/core/settings.cpp` (+2 -0) 📝 `src/core/settings.h` (+1 -0) 📝 `src/core/shadergen.cpp` (+2 -1) </details> ### 📄 Description As found in #1026, old Radeon OGL driver has issues with the qualifier used for SSAA and Interface Blocks. This PR adds an INI setting that allows to disable shader Interface Blocks from being used and avoid the bug. Currently, I've been just making custom builds with the interface blocks disabled so I decided to try and make a setting for it. It's the least invasive way I found, although it exposes global settings to the shader generator. No UI settings either, too hacky for "advanced" even. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:08:00 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#452