[PR #1344] [MERGED] Use gtk3 for nativefiledialog #461

New Issue

claunia · 2026-01-29T19:08:02Z

claunia commented

2026-01-29 19:08:02 +00:00

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/1344
Author: @guibou
Created: 12/29/2020
Status: ✅ Merged
Merged: 12/29/2020
Merged by: @stenzek

Base: master ← Head: gtk3

📝 Commits (1)

f30addc Use gtk3 for nativefiledialog

📊 Changes

3 files changed (+8 additions, -6 deletions)

View changed files

📝 .github/workflows/rolling-release.yml (+1 -1)
📝 README.md (+2 -1)
📝 dep/nativefiledialog/CMakeLists.txt (+5 -4)

📄 Description

Rational: gtk2 is not maintained anymore and the change was simple.

Update of nativefiledialog/CMakeLists.txt in order to detect and use
gtk3
Updated a few files referencing gtk2, especially:
- github workflow: I tested that the apt-get update works on ubuntu
  18.03 in a docker container
- Readme.

This was tested in the following nixpkgs PR: https://github.com/NixOS/nixpkgs/pull/107878

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/1344 **Author:** [@guibou](https://github.com/guibou) **Created:** 12/29/2020 **Status:** ✅ Merged **Merged:** 12/29/2020 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `gtk3` --- ### 📝 Commits (1) - [`f30addc`](https://github.com/stenzek/duckstation/commit/f30addc70dc104e5dfcafd25e3e9ab6fd792a341) Use gtk3 for nativefiledialog ### 📊 Changes **3 files changed** (+8 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/rolling-release.yml` (+1 -1) 📝 `README.md` (+2 -1) 📝 `dep/nativefiledialog/CMakeLists.txt` (+5 -4) </details> ### 📄 Description Rational: gtk2 is not maintained anymore and the change was simple. - Update of nativefiledialog/CMakeLists.txt in order to detect and use gtk3 - Updated a few files referencing gtk2, especially: - github workflow: I tested that the apt-get update works on ubuntu 18.03 in a docker container - Readme. This was tested in the following nixpkgs PR: https://github.com/NixOS/nixpkgs/pull/107878 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 19:08:02 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/duckstation#461