starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #1344] Use gtk3 for nativefiledialog #466

New Issue
Closed
opened 2026-01-29 19:08:03 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:08:03 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/stenzek/duckstation/pull/1344

State: closed
Merged: Yes

Rational: gtk2 is not maintained anymore and the change was simple.

  • Update of nativefiledialog/CMakeLists.txt in order to detect and use
    gtk3
  • Updated a few files referencing gtk2, especially:
    • github workflow: I tested that the apt-get update works on ubuntu
      18.03 in a docker container
    • Readme.

This was tested in the following nixpkgs PR: https://github.com/NixOS/nixpkgs/pull/107878

**Original Pull Request:** https://github.com/stenzek/duckstation/pull/1344 **State:** closed **Merged:** Yes --- Rational: gtk2 is not maintained anymore and the change was simple. - Update of nativefiledialog/CMakeLists.txt in order to detect and use gtk3 - Updated a few files referencing gtk2, especially: - github workflow: I tested that the apt-get update works on ubuntu 18.03 in a docker container - Readme. This was tested in the following nixpkgs PR: https://github.com/NixOS/nixpkgs/pull/107878
claunia added the pull-request label 2026-01-29 19:08:03 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#466
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?