[PR #603] [MERGED] GPU: Compute VRAM display width from GP1(06h) values #54

New Issue

claunia · 2026-01-29T19:06:13Z

claunia commented

2026-01-29 19:06:13 +00:00

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/603
Author: @ggrtk
Created: 7/11/2020
Status: ✅ Merged
Merged: 7/12/2020
Merged by: @stenzek

Base: master ← Head: gpu-crtc

📝 Commits (1)

c44e74d GPU: Compute VRAM display width from GP1(06h) values

📊 Changes

1 file changed (+9 additions, -18 deletions)

View changed files

📝 src/core/gpu.cpp (+9 -18)

📄 Description

We should be applying crop after determining the VRAM display width from GPU values rather than calculating it from the number of video clock ticks in the configurable visible display region. This is a better representation of what happens in hardware, since the GPU has no concept of what's visible or not on the user side, and is less susceptible to rounding errors than the previous method.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/603 **Author:** [@ggrtk](https://github.com/ggrtk) **Created:** 7/11/2020 **Status:** ✅ Merged **Merged:** 7/12/2020 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `gpu-crtc` --- ### 📝 Commits (1) - [`c44e74d`](https://github.com/stenzek/duckstation/commit/c44e74db803cf977e4d1bb7604f41aea6cedaa77) GPU: Compute VRAM display width from GP1(06h) values ### 📊 Changes **1 file changed** (+9 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/core/gpu.cpp` (+9 -18) </details> ### 📄 Description We should be applying crop after determining the VRAM display width from GPU values rather than calculating it from the number of video clock ticks in the configurable visible display region. This is a better representation of what happens in hardware, since the GPU has no concept of what's visible or not on the user side, and is less susceptible to rounding errors than the previous method. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 19:06:13 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/duckstation#54