starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #1580] [MERGED] Update shadergen.cpp #558

New Issue
Open
opened 2026-01-29 19:08:33 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:08:33 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/1580
Author: @MaddTheSane
Created: 2/4/2021
Status: ✅ Merged
Merged: 2/5/2021
Merged by: @stenzek

Base: master ← Head: patch-2

📝 Commits (1)

📊 Changes

1 file changed (+6 additions, -6 deletions)

View changed files

📝 src/core/shadergen.cpp (+6 -6)

📄 Description

Quiets a warning in Clang about copying variables.

Actual warning text:

Loop variable '[qualifiers, name]' of type 'const std::__1::pair<const char *, const char *>' creates a copy from type 'const std::__1::pair<const char *, const char *>'
Use reference type 'const std::__1::pair<const char *, const char *> &' to prevent copying

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/1580 **Author:** [@MaddTheSane](https://github.com/MaddTheSane) **Created:** 2/4/2021 **Status:** ✅ Merged **Merged:** 2/5/2021 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `patch-2` --- ### 📝 Commits (1) - [`2c2af6c`](https://github.com/stenzek/duckstation/commit/2c2af6c751ab7edf95a61a6112eb994ede45420b) Update shadergen.cpp ### 📊 Changes **1 file changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/core/shadergen.cpp` (+6 -6) </details> ### 📄 Description Quiets a warning in Clang about copying variables. Actual warning text: > Loop variable '[qualifiers, name]' of type 'const std::__1::pair<const char *, const char *>' creates a copy from type 'const std::__1::pair<const char *, const char *>' > Use reference type 'const std::__1::pair<const char *, const char *> &' to prevent copying --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:08:33 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#558
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?