starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #1657] [MERGED] Save State UI: Add legend showing hotkeys #602

New Issue
Open
opened 2026-01-29 19:08:45 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:08:45 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/1657
Author: @CookiePLMonster
Created: 2/17/2021
Status: ✅ Merged
Merged: 2/23/2021
Merged by: @stenzek

Base: master ← Head: savestate-ui-legend

📝 Commits (3)

  • 82a2175 Save State UI: Add legend showing hotkeys
  • e361b9f Save State UI: Make the widget translatable
  • 78f9136 Save State UI: Cache legend strings

📊 Changes

3 files changed (+110 additions, -33 deletions)

View changed files

📝 src/frontend-common/common_host_interface.cpp (+2 -0)
📝 src/frontend-common/save_state_selector_ui.cpp (+100 -32)
📝 src/frontend-common/save_state_selector_ui.h (+8 -1)

📄 Description

This PR adds a legend to the Save State Selector UI. In my experience, I kept misremembering Save/Load buttons and using the wrong one when on this screen, so a legend should help.

To do:

  • Style the legend better? Most notably, some margins may be needed.
  • Strip the device name maybe - F1 or Button14 might be good enough in this case.
  • Make the legend translatable

Current look:
image
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/1657 **Author:** [@CookiePLMonster](https://github.com/CookiePLMonster) **Created:** 2/17/2021 **Status:** ✅ Merged **Merged:** 2/23/2021 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `savestate-ui-legend` --- ### 📝 Commits (3) - [`82a2175`](https://github.com/stenzek/duckstation/commit/82a217570c5006fa6eac97d2b898526133ffc246) Save State UI: Add legend showing hotkeys - [`e361b9f`](https://github.com/stenzek/duckstation/commit/e361b9f0126efe366ca16fc3a8c763e3740ddc61) Save State UI: Make the widget translatable - [`78f9136`](https://github.com/stenzek/duckstation/commit/78f9136fb8629f8af818c030181dd1bacf20246f) Save State UI: Cache legend strings ### 📊 Changes **3 files changed** (+110 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `src/frontend-common/common_host_interface.cpp` (+2 -0) 📝 `src/frontend-common/save_state_selector_ui.cpp` (+100 -32) 📝 `src/frontend-common/save_state_selector_ui.h` (+8 -1) </details> ### 📄 Description This PR adds a legend to the Save State Selector UI. In my experience, I kept misremembering Save/Load buttons and using the wrong one when on this screen, so a legend should help. To do: * ~~Style the legend better? Most notably, some margins may be needed.~~ * ~~Strip the device name maybe - `F1` or `Button14` might be good enough in this case.~~ * ~~Make the legend translatable~~ Current look: ![image](https://user-images.githubusercontent.com/7947461/108550700-352fb000-72ef-11eb-902b-0219e879232c.png) ![image](https://user-images.githubusercontent.com/7947461/108550783-4ed0f780-72ef-11eb-919b-b1414839cd63.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:08:45 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#602
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?