starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #617] [MERGED] Qt: Replace QtSettingsInterface with INISettingsInterface #63

New Issue
Open
opened 2026-01-29 19:06:15 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:06:15 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/617
Author: @ggrtk
Created: 7/17/2020
Status: ✅ Merged
Merged: 7/21/2020
Merged by: @stenzek

Base: master ← Head: qt-inisettings

📝 Commits (6)

  • 9d6325f QtHostInterface: Fix compiler warning
  • 9b2740b HostInterface: Save tweak/hack defaults to settings file
  • 4e2b318 Qt: Replace QtSettingsInterface with INISettingsInterface
  • 97be6c9 Fix MSVC build
  • 79adabe CommonHostInterface: Bump to settings version 3
  • bddd098 Merge branch 'master' into qt-inisettings

📊 Changes

23 files changed (+352 additions, -470 deletions)

View changed files

📝 src/core/host_interface.cpp (+5 -0)
📝 src/duckstation-qt/CMakeLists.txt (+0 -2)
📝 src/duckstation-qt/advancedsettingswidget.cpp (+21 -17)
📝 src/duckstation-qt/audiosettingswidget.cpp (+13 -8)
📝 src/duckstation-qt/consolesettingswidget.cpp (+17 -12)
📝 src/duckstation-qt/controllersettingswidget.cpp (+28 -20)
📝 src/duckstation-qt/duckstation-qt.vcxproj (+8 -10)
📝 src/duckstation-qt/duckstation-qt.vcxproj.filters (+0 -2)
📝 src/duckstation-qt/gamelistsettingswidget.cpp (+10 -10)
📝 src/duckstation-qt/gamelistwidget.cpp (+10 -12)
📝 src/duckstation-qt/generalsettingswidget.cpp (+28 -18)
📝 src/duckstation-qt/gpusettingswidget.cpp (+32 -29)
📝 src/duckstation-qt/hotkeysettingswidget.cpp (+3 -2)
📝 src/duckstation-qt/inputbindingwidgets.cpp (+19 -14)
📝 src/duckstation-qt/inputbindingwidgets.h (+6 -5)
📝 src/duckstation-qt/mainwindow.cpp (+22 -18)
📝 src/duckstation-qt/memorycardsettingswidget.cpp (+2 -2)
📝 src/duckstation-qt/qthostinterface.cpp (+67 -50)
📝 src/duckstation-qt/qthostinterface.h (+12 -7)
➖ src/duckstation-qt/qtsettingsinterface.cpp (+0 -147)

...and 3 more files

📄 Description

One thing I'm concerned about is that users will have their settings deleted without much warning, since a pop-up window doesn't seem to get created when a settings version mismatch is found, like it does when there is a save state version mismatch.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/617 **Author:** [@ggrtk](https://github.com/ggrtk) **Created:** 7/17/2020 **Status:** ✅ Merged **Merged:** 7/21/2020 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `qt-inisettings` --- ### 📝 Commits (6) - [`9d6325f`](https://github.com/stenzek/duckstation/commit/9d6325f828a740e77efea04c2e723004e356c153) QtHostInterface: Fix compiler warning - [`9b2740b`](https://github.com/stenzek/duckstation/commit/9b2740b3952107a3967c0abd93e0187d6cf9d659) HostInterface: Save tweak/hack defaults to settings file - [`4e2b318`](https://github.com/stenzek/duckstation/commit/4e2b3189b0ae4a3f71a7e4cbdb8fc41364a57fe9) Qt: Replace QtSettingsInterface with INISettingsInterface - [`97be6c9`](https://github.com/stenzek/duckstation/commit/97be6c922c75e30675a62983f3a17a1aa16ca08c) Fix MSVC build - [`79adabe`](https://github.com/stenzek/duckstation/commit/79adabeb91caa68dc5308da2b80d2140a3d69841) CommonHostInterface: Bump to settings version 3 - [`bddd098`](https://github.com/stenzek/duckstation/commit/bddd098a66275db1dac80e252d27c0f433d4c92f) Merge branch 'master' into qt-inisettings ### 📊 Changes **23 files changed** (+352 additions, -470 deletions) <details> <summary>View changed files</summary> 📝 `src/core/host_interface.cpp` (+5 -0) 📝 `src/duckstation-qt/CMakeLists.txt` (+0 -2) 📝 `src/duckstation-qt/advancedsettingswidget.cpp` (+21 -17) 📝 `src/duckstation-qt/audiosettingswidget.cpp` (+13 -8) 📝 `src/duckstation-qt/consolesettingswidget.cpp` (+17 -12) 📝 `src/duckstation-qt/controllersettingswidget.cpp` (+28 -20) 📝 `src/duckstation-qt/duckstation-qt.vcxproj` (+8 -10) 📝 `src/duckstation-qt/duckstation-qt.vcxproj.filters` (+0 -2) 📝 `src/duckstation-qt/gamelistsettingswidget.cpp` (+10 -10) 📝 `src/duckstation-qt/gamelistwidget.cpp` (+10 -12) 📝 `src/duckstation-qt/generalsettingswidget.cpp` (+28 -18) 📝 `src/duckstation-qt/gpusettingswidget.cpp` (+32 -29) 📝 `src/duckstation-qt/hotkeysettingswidget.cpp` (+3 -2) 📝 `src/duckstation-qt/inputbindingwidgets.cpp` (+19 -14) 📝 `src/duckstation-qt/inputbindingwidgets.h` (+6 -5) 📝 `src/duckstation-qt/mainwindow.cpp` (+22 -18) 📝 `src/duckstation-qt/memorycardsettingswidget.cpp` (+2 -2) 📝 `src/duckstation-qt/qthostinterface.cpp` (+67 -50) 📝 `src/duckstation-qt/qthostinterface.h` (+12 -7) ➖ `src/duckstation-qt/qtsettingsinterface.cpp` (+0 -147) _...and 3 more files_ </details> ### 📄 Description One thing I'm concerned about is that users will have their settings deleted without much warning, since a pop-up window doesn't seem to get created when a settings version mismatch is found, like it does when there is a save state version mismatch. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:06:15 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#63
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?