[PR #622] [MERGED] Qt/GameListSettings: Use native path separators #65

New Issue

claunia · 2026-01-29T19:06:15Z

claunia commented

2026-01-29 19:06:15 +00:00

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/622
Author: @ggrtk
Created: 7/18/2020
Status: ✅ Merged
Merged: 7/19/2020
Merged by: @stenzek

Base: master ← Head: qt-gamelistsettings

📝 Commits (1)

2853bf8 Qt/GameListSettings: Use native path separators

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 src/duckstation-qt/gamelistsettingswidget.cpp (+3 -1)

📄 Description

QFileDialog::getExistingDirectory() returns paths with forward slash by default. This path string eventually gets passed to FileSystem::FindFiles() which constructs the rest of the path string using native path separators. This means that for example if on Windows we had added C:/path/to/game non-recursively and C:/path/to recursively through Qt, we would find C:/path/to/game\x.cue and C:/path/to\game\x.cue, resulting in the same game appearing twice on the game list.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/622 **Author:** [@ggrtk](https://github.com/ggrtk) **Created:** 7/18/2020 **Status:** ✅ Merged **Merged:** 7/19/2020 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `qt-gamelistsettings` --- ### 📝 Commits (1) - [`2853bf8`](https://github.com/stenzek/duckstation/commit/2853bf851ac91828c3ed86784103d4ea27a99cb3) Qt/GameListSettings: Use native path separators ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/duckstation-qt/gamelistsettingswidget.cpp` (+3 -1) </details> ### 📄 Description `QFileDialog::getExistingDirectory()` returns paths with forward slash by default. This path string eventually gets passed to `FileSystem::FindFiles()` which constructs the rest of the path string using native path separators. This means that for example if on Windows we had added `C:/path/to/game` non-recursively and `C:/path/to` recursively through Qt, we would find `C:/path/to/game\x.cue` and `C:/path/to\game\x.cue`, resulting in the same game appearing twice on the game list. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 19:06:15 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/duckstation#65