starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #1726] [MERGED] Misc Qt stuff #667

New Issue
Open
opened 2026-01-29 19:09:01 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:09:01 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/1726
Author: @CookiePLMonster
Created: 3/2/2021
Status: ✅ Merged
Merged: 3/5/2021
Merged by: @stenzek

Base: master ← Head: misc-qt-stuff

📝 Commits (3)

  • edeed89 Add support for plural forms in Qt forms
  • c0b7ee5 Fix "Stretch to fill" widget help
  • 84bec06 Use QString::number where applicable

📊 Changes

16 files changed (+85 additions, -26 deletions)

View changed files

📝 src/duckstation-qt/CMakeLists.txt (+1 -0)
📝 src/duckstation-qt/audiosettingswidget.cpp (+1 -2)
📝 src/duckstation-qt/autoupdaterdialog.cpp (+1 -1)
📝 src/duckstation-qt/cheatmanagerdialog.cpp (+2 -2)
📝 src/duckstation-qt/displaysettingswidget.cpp (+1 -1)
📝 src/duckstation-qt/duckstation-qt.vcxproj (+3 -0)
📝 src/duckstation-qt/duckstation-qt.vcxproj.filters (+3 -0)
📝 src/duckstation-qt/emulationsettingswidget.cpp (+1 -2)
📝 src/duckstation-qt/gamepropertiesdialog.cpp (+1 -1)
📝 src/duckstation-qt/inputbindingwidgets.cpp (+1 -1)
📝 src/duckstation-qt/memorycardeditordialog.cpp (+2 -2)
📝 src/duckstation-qt/postprocessingshaderconfigwidget.cpp (+7 -7)
📝 src/duckstation-qt/qthostinterface.cpp (+2 -2)
📝 src/duckstation-qt/settingwidgetbinder.h (+5 -5)
➕ src/duckstation-qt/translations/duckstation-qt_en.ts (+44 -0)
➕ src/duckstation-qt/translations/update-and-edit-english.bat (+10 -0)

📄 Description

IMPORTANT NOTE: If it's not done automatically, duckstation-qt_en.qm must be added to the artifacts!

  1. Hooks up plurality for English. So far very few strings utilize it, because we can't yet use plurality outside of Qt strings. It'll be much more useful once it's in there though, for strings like X cheats loaded etc.
  2. "Stretch to fill" had a broken widget help assignment.
  3. As far as I can tell, QStringLiteral("%1").arg(num) can be simplified to QString::number(num), so I did a full sweep through the codebase.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/1726 **Author:** [@CookiePLMonster](https://github.com/CookiePLMonster) **Created:** 3/2/2021 **Status:** ✅ Merged **Merged:** 3/5/2021 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `misc-qt-stuff` --- ### 📝 Commits (3) - [`edeed89`](https://github.com/stenzek/duckstation/commit/edeed89648822e4229a3d2b6d19b5ee90b01d7ea) Add support for plural forms in Qt forms - [`c0b7ee5`](https://github.com/stenzek/duckstation/commit/c0b7ee5722b59e94362e6ed4bd971bdb91d5d312) Fix "Stretch to fill" widget help - [`84bec06`](https://github.com/stenzek/duckstation/commit/84bec06a90ab415434c80163b05832daac2b7457) Use QString::number where applicable ### 📊 Changes **16 files changed** (+85 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `src/duckstation-qt/CMakeLists.txt` (+1 -0) 📝 `src/duckstation-qt/audiosettingswidget.cpp` (+1 -2) 📝 `src/duckstation-qt/autoupdaterdialog.cpp` (+1 -1) 📝 `src/duckstation-qt/cheatmanagerdialog.cpp` (+2 -2) 📝 `src/duckstation-qt/displaysettingswidget.cpp` (+1 -1) 📝 `src/duckstation-qt/duckstation-qt.vcxproj` (+3 -0) 📝 `src/duckstation-qt/duckstation-qt.vcxproj.filters` (+3 -0) 📝 `src/duckstation-qt/emulationsettingswidget.cpp` (+1 -2) 📝 `src/duckstation-qt/gamepropertiesdialog.cpp` (+1 -1) 📝 `src/duckstation-qt/inputbindingwidgets.cpp` (+1 -1) 📝 `src/duckstation-qt/memorycardeditordialog.cpp` (+2 -2) 📝 `src/duckstation-qt/postprocessingshaderconfigwidget.cpp` (+7 -7) 📝 `src/duckstation-qt/qthostinterface.cpp` (+2 -2) 📝 `src/duckstation-qt/settingwidgetbinder.h` (+5 -5) ➕ `src/duckstation-qt/translations/duckstation-qt_en.ts` (+44 -0) ➕ `src/duckstation-qt/translations/update-and-edit-english.bat` (+10 -0) </details> ### 📄 Description **IMPORTANT NOTE:** If it's not done automatically, `duckstation-qt_en.qm` must be added to the artifacts! 1. Hooks up plurality for English. So far very few strings utilize it, because we can't yet use plurality outside of Qt strings. It'll be much more useful once it's in there though, for strings like `X cheats loaded` etc. 2. "Stretch to fill" had a broken widget help assignment. 3. As far as I can tell, `QStringLiteral("%1").arg(num)` can be simplified to `QString::number(num)`, so I did a full sweep through the codebase. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:09:01 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#667
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?