starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #1769] [MERGED] Fix quick menu exit #696

New Issue
Open
opened 2026-01-29 19:09:10 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:09:10 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/1769
Author: @CookiePLMonster
Created: 3/8/2021
Status: ✅ Merged
Merged: 3/9/2021
Merged by: @stenzek

Base: master ← Head: fix-quick-menu-exit

📝 Commits (2)

  • 3849ec4 Revert "CommonHostInterface: Use key-release to open quick menu"
  • 435a848 FullscreenUI: Close menus on Cancel button edge only

📊 Changes

2 files changed (+26 additions, -6 deletions)

View changed files

📝 src/frontend-common/common_host_interface.cpp (+1 -1)
📝 src/frontend-common/fullscreen_ui.cpp (+25 -5)

📄 Description

Now requires the button to be released, then pressed. With this change, e0161c3bb2 can be reverted.

Should this logic be applied to DrawChoiceDialog and DrawFileSelector in imgui_fullscreen.cpp? If so, maybe it is better to move it there instead of fullscreen_ui.cpp.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/1769 **Author:** [@CookiePLMonster](https://github.com/CookiePLMonster) **Created:** 3/8/2021 **Status:** ✅ Merged **Merged:** 3/9/2021 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `fix-quick-menu-exit` --- ### 📝 Commits (2) - [`3849ec4`](https://github.com/stenzek/duckstation/commit/3849ec449bd88fb147eebb741539905f0ed9668c) Revert "CommonHostInterface: Use key-release to open quick menu" - [`435a848`](https://github.com/stenzek/duckstation/commit/435a8485597e1412eeb9ddccb51f17b325c180ea) FullscreenUI: Close menus on Cancel button edge only ### 📊 Changes **2 files changed** (+26 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/frontend-common/common_host_interface.cpp` (+1 -1) 📝 `src/frontend-common/fullscreen_ui.cpp` (+25 -5) </details> ### 📄 Description Now requires the button to be released, **then** pressed. With this change, e0161c3bb2f5e5f4e9d7f9569ba86010899c08c5 can be reverted. Should this logic be applied to `DrawChoiceDialog` and `DrawFileSelector` in `imgui_fullscreen.cpp`? If so, maybe it is better to move it there instead of `fullscreen_ui.cpp`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:09:10 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#696
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?