starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #1770] [MERGED] Achievements Login: Lock "Login" button if credentials are not entered #697

New Issue
Open
opened 2026-01-29 19:09:10 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:09:10 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/1770
Author: @CookiePLMonster
Created: 3/8/2021
Status: ✅ Merged
Merged: 3/9/2021
Merged by: @stenzek

Base: master ← Head: lock-login-button

📝 Commits (2)

  • 3849ec4 Revert "CommonHostInterface: Use key-release to open quick menu"
  • 08b2f6c AchievementLoginDialog: Lock out "Login" if fields aren't filled

📊 Changes

4 files changed (+15 additions, -7 deletions)

View changed files

📝 src/duckstation-qt/achievementlogindialog.cpp (+10 -6)
📝 src/duckstation-qt/achievementlogindialog.h (+1 -0)
📝 src/duckstation-qt/achievementlogindialog.ui (+3 -0)
📝 src/frontend-common/common_host_interface.cpp (+1 -1)

📄 Description

Bigduck does this already, Qt did not - Login is now locked if credentials are not entered:

image
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/1770 **Author:** [@CookiePLMonster](https://github.com/CookiePLMonster) **Created:** 3/8/2021 **Status:** ✅ Merged **Merged:** 3/9/2021 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `lock-login-button` --- ### 📝 Commits (2) - [`3849ec4`](https://github.com/stenzek/duckstation/commit/3849ec449bd88fb147eebb741539905f0ed9668c) Revert "CommonHostInterface: Use key-release to open quick menu" - [`08b2f6c`](https://github.com/stenzek/duckstation/commit/08b2f6c715b579bd89dce312a0daa72d92a9a43a) AchievementLoginDialog: Lock out "Login" if fields aren't filled ### 📊 Changes **4 files changed** (+15 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/duckstation-qt/achievementlogindialog.cpp` (+10 -6) 📝 `src/duckstation-qt/achievementlogindialog.h` (+1 -0) 📝 `src/duckstation-qt/achievementlogindialog.ui` (+3 -0) 📝 `src/frontend-common/common_host_interface.cpp` (+1 -1) </details> ### 📄 Description Bigduck does this already, Qt did not - `Login` is now locked if credentials are not entered: ![image](https://user-images.githubusercontent.com/7947461/110377666-f884e800-8054-11eb-93c4-63c912501b43.png) ![image](https://user-images.githubusercontent.com/7947461/110377676-fc186f00-8054-11eb-9dcc-e710086f0785.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:09:10 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#697
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?