starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #641] [MERGED] CommonHostInterface: Prevent some potential null pointer dereferences #72

New Issue
Open
opened 2026-01-29 19:06:17 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:06:17 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/641
Author: @ggrtk
Created: 7/22/2020
Status: ✅ Merged
Merged: 7/22/2020
Merged by: @stenzek

Base: master ← Head: nullptr-fix

📝 Commits (1)

  • 855fc9a CommonHostInterface: Prevent some potential null pointer dereferences

📊 Changes

2 files changed (+8 additions, -2 deletions)

View changed files

📝 src/duckstation-qt/qthostinterface.cpp (+3 -0)
📝 src/frontend-common/common_host_interface.cpp (+5 -2)

📄 Description

This should fix issue #638.

Might also need to block controller polling for a short period of time or something to that effect to prevent the hotkey functionality from being engaged instantly after being registered, but that's a separate issue from the crash.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/641 **Author:** [@ggrtk](https://github.com/ggrtk) **Created:** 7/22/2020 **Status:** ✅ Merged **Merged:** 7/22/2020 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `nullptr-fix` --- ### 📝 Commits (1) - [`855fc9a`](https://github.com/stenzek/duckstation/commit/855fc9a31c0fed65566ec35af5320fa0a597876f) CommonHostInterface: Prevent some potential null pointer dereferences ### 📊 Changes **2 files changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/duckstation-qt/qthostinterface.cpp` (+3 -0) 📝 `src/frontend-common/common_host_interface.cpp` (+5 -2) </details> ### 📄 Description This should fix issue #638. Might also need to block controller polling for a short period of time or something to that effect to prevent the hotkey functionality from being engaged instantly after being registered, but that's a separate issue from the crash. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:06:17 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#72
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?