[PR #506] [MERGED] Update input profiles and input profile handling #8

New Issue

claunia · 2026-01-29T19:06:01Z

claunia commented

2026-01-29 19:06:01 +00:00

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/506
Author: @ggrtk
Created: 5/28/2020
Status: ✅ Merged
Merged: 5/28/2020
Merged by: @stenzek

Base: master ← Head: analog-controller

📝 Commits (5)

1f74d46 AnalogController: Use proper upper bound when validating axis_code
ca873cf InputProfiles: Update DualShock 4 input profile
b5311e5 InputProfiles: Add PlayStation Classic Controller input profile
f8fea1b INISettingsInterface: Return bool on saving settings
e1e3cf4 CommonHostInterface: Simplify input profile saving

📊 Changes

6 files changed (+59 additions, -34 deletions)

View changed files

📝 data/inputprofiles/DualShock 4.ini (+23 -21)
➕ data/inputprofiles/PlayStation Classic Controller.ini (+16 -0)
📝 src/core/analog_controller.cpp (+1 -1)
📝 src/frontend-common/common_host_interface.cpp (+11 -8)
📝 src/frontend-common/ini_settings_interface.cpp (+7 -3)
📝 src/frontend-common/ini_settings_interface.h (+1 -1)

📄 Description

Sort of a multi-facted PR for a couple of small things.

Of note, the updated DualShock 4 input profile also works for DualShock 3 on Linux, although I wasn't able to get it to work with the DualShock 3 on Windows. There's probably some driver-related shenanigans going on there. Rumble doesn't work for either gamepad on Windows, but I think this is expected for non-XInput devices on Windows going through SDL.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/506 **Author:** [@ggrtk](https://github.com/ggrtk) **Created:** 5/28/2020 **Status:** ✅ Merged **Merged:** 5/28/2020 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `analog-controller` --- ### 📝 Commits (5) - [`1f74d46`](https://github.com/stenzek/duckstation/commit/1f74d46d3951a2b58e3a8ee2469348221c53220e) AnalogController: Use proper upper bound when validating axis_code - [`ca873cf`](https://github.com/stenzek/duckstation/commit/ca873cf24387e4cbb1c4b02b326d56622c8816a3) InputProfiles: Update DualShock 4 input profile - [`b5311e5`](https://github.com/stenzek/duckstation/commit/b5311e5896a5e83dcae12b8dc7490ed26b0dd877) InputProfiles: Add PlayStation Classic Controller input profile - [`f8fea1b`](https://github.com/stenzek/duckstation/commit/f8fea1b21595808d04109c0ecb66e3e5b954d2d0) INISettingsInterface: Return bool on saving settings - [`e1e3cf4`](https://github.com/stenzek/duckstation/commit/e1e3cf4f5a0c338d76c6667be007ea77936a63ae) CommonHostInterface: Simplify input profile saving ### 📊 Changes **6 files changed** (+59 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `data/inputprofiles/DualShock 4.ini` (+23 -21) ➕ `data/inputprofiles/PlayStation Classic Controller.ini` (+16 -0) 📝 `src/core/analog_controller.cpp` (+1 -1) 📝 `src/frontend-common/common_host_interface.cpp` (+11 -8) 📝 `src/frontend-common/ini_settings_interface.cpp` (+7 -3) 📝 `src/frontend-common/ini_settings_interface.h` (+1 -1) </details> ### 📄 Description Sort of a multi-facted PR for a couple of small things. Of note, the updated DualShock 4 input profile also works for DualShock 3 on Linux, although I wasn't able to get it to work with the DualShock 3 on Windows. There's probably some driver-related shenanigans going on there. Rumble doesn't work for either gamepad on Windows, but I think this is expected for non-XInput devices on Windows going through SDL. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 19:06:01 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/duckstation#8