starred/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2026-02-04 05:04:33 +00:00
Code Issues 1.1k Packages Projects Releases 20 Wiki Activity

[PR #2174] [MERGED] Common/DimensionalArray: Re-revert the workaround #908

New Issue
Open
opened 2026-01-29 19:10:07 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 19:10:07 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/stenzek/duckstation/pull/2174
Author: @CookiePLMonster
Created: 5/25/2021
Status: ✅ Merged
Merged: 5/26/2021
Merged by: @stenzek

Base: master ← Head: vs2019-workaround

📝 Commits (1)

  • 803b68b Common/DimensionalArray: Re-revert the workaround

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/common/dimensional_array.h (+2 -2)

📄 Description

VS16.10 fixes the regression and bumps up _MSC_VER, so make only VS2017 and VS16.9 use the workaround

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/stenzek/duckstation/pull/2174 **Author:** [@CookiePLMonster](https://github.com/CookiePLMonster) **Created:** 5/25/2021 **Status:** ✅ Merged **Merged:** 5/26/2021 **Merged by:** [@stenzek](https://github.com/stenzek) **Base:** `master` ← **Head:** `vs2019-workaround` --- ### 📝 Commits (1) - [`803b68b`](https://github.com/stenzek/duckstation/commit/803b68b2795299870da9858f6651e8e04b9a43b7) Common/DimensionalArray: Re-revert the workaround ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/common/dimensional_array.h` (+2 -2) </details> ### 📄 Description VS16.10 fixes the regression and bumps up _MSC_VER, so make only VS2017 and VS16.9 use the workaround --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 19:10:07 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/duckstation#908
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?