From 88c5b5cb410f7c8507e61dca4731e6e558bfa78b Mon Sep 17 00:00:00 2001 From: Melodi <62381002+Melodi17@users.noreply.github.com> Date: Tue, 31 Dec 2024 22:57:02 +1000 Subject: [PATCH 1/2] Added method for clearing indents in TextRendererBase as well as added case handling to PopIndent() --- src/Markdig/Renderers/TextRendererBase.cs | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/Markdig/Renderers/TextRendererBase.cs b/src/Markdig/Renderers/TextRendererBase.cs index 4d428a77..ef4dd525 100644 --- a/src/Markdig/Renderers/TextRendererBase.cs +++ b/src/Markdig/Renderers/TextRendererBase.cs @@ -1,5 +1,5 @@ // Copyright (c) Alexandre Mutel. All rights reserved. -// This file is licensed under the BSD-Clause 2 license. +// This file is licensed under the BSD-Clause 2 license. // See the license.txt file in the project root for more information. using System.Diagnostics.CodeAnalysis; @@ -174,10 +174,12 @@ public abstract class TextRendererBase : TextRendererBase where T : TextRende public void PopIndent() { - // TODO: Check - indents.RemoveAt(indents.Count - 1); + if (this.indents.Count > 0) + indents.RemoveAt(indents.Count - 1); } + public void ClearIndent() => indents.Clear(); + [MethodImpl(MethodImplOptions.AggressiveInlining)] private protected void WriteIndent() { @@ -220,12 +222,12 @@ public abstract class TextRendererBase : TextRendererBase where T : TextRende [MethodImpl(MethodImplOptions.AggressiveInlining)] internal T Write(char c, int count) { - WriteIndent(); - + WriteIndent(); + for (int i = 0; i < count; i++) { Writer.Write(c); - } + } return (T)this; } From 148278417f5aeee2e523ee9ad2fea4500320fa23 Mon Sep 17 00:00:00 2001 From: Melodi <62381002+Melodi17@users.noreply.github.com> Date: Tue, 14 Jan 2025 14:25:20 +1000 Subject: [PATCH 2/2] Added error throwing when stack is empty and PopIndent() is called --- src/Markdig/Renderers/TextRendererBase.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Markdig/Renderers/TextRendererBase.cs b/src/Markdig/Renderers/TextRendererBase.cs index ef4dd525..cb2b0da1 100644 --- a/src/Markdig/Renderers/TextRendererBase.cs +++ b/src/Markdig/Renderers/TextRendererBase.cs @@ -176,6 +176,8 @@ public abstract class TextRendererBase : TextRendererBase where T : TextRende { if (this.indents.Count > 0) indents.RemoveAt(indents.Count - 1); + else + throw new InvalidOperationException("No indent to pop"); } public void ClearIndent() => indents.Clear();