starred/markdig
1
0
Fork 0
mirror of https://github.com/xoofx/markdig.git synced 2026-02-12 21:39:32 +00:00
Code Issues 690 Packages Projects Releases 21 Wiki Activity

[PR #435] [MERGED] Fix media link classes not being added #1034

New Issue
Open
opened 2026-01-29 14:48:55 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 14:48:55 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/xoofx/markdig/pull/435
Author: @RudeySH
Created: 5/12/2020
Status: ✅ Merged
Merged: 6/9/2020
Merged by: @xoofx

Base: master ← Head: patch-1

📝 Commits (5)

  • 6e0363a Fix media link classes not being added
  • 42462d7 Reorder class attribute in test cases
  • ba192ce Remove redundancy, apply same fix to audio/video
  • d53128d Reorder class attribute in spec tests
  • ea67a29 Test CSS classes using both Bootstrap and MediaLinks

📊 Changes

4 files changed (+58 additions, -41 deletions)

View changed files

📝 src/Markdig.Tests/Specs/MediaSpecs.generated.cs (+13 -13)
📝 src/Markdig.Tests/Specs/MediaSpecs.md (+11 -11)
📝 src/Markdig.Tests/TestMediaLinks.cs (+28 -11)
📝 src/Markdig/Extensions/MediaLinks/MediaLinkExtension.cs (+6 -6)

📄 Description

I noticed this when using both the Bootstrap extension and the Media Links extension. When Bootstraps adds img-fluid, the Media Link extension didn't add their classes as well. This PR should fix that.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/xoofx/markdig/pull/435 **Author:** [@RudeySH](https://github.com/RudeySH) **Created:** 5/12/2020 **Status:** ✅ Merged **Merged:** 6/9/2020 **Merged by:** [@xoofx](https://github.com/xoofx) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (5) - [`6e0363a`](https://github.com/xoofx/markdig/commit/6e0363aa91b64efb52319e4fdd7af1474e16987b) Fix media link classes not being added - [`42462d7`](https://github.com/xoofx/markdig/commit/42462d71aca8747649dca9c515b23a498e0c2d0d) Reorder class attribute in test cases - [`ba192ce`](https://github.com/xoofx/markdig/commit/ba192ce0657d07f6c9015a1bc853089f7d76c9f2) Remove redundancy, apply same fix to audio/video - [`d53128d`](https://github.com/xoofx/markdig/commit/d53128d56d18eedc50ca227218d41c8b9bccd79c) Reorder class attribute in spec tests - [`ea67a29`](https://github.com/xoofx/markdig/commit/ea67a295b2cc118389ffc00ee6057df007c2e0ce) Test CSS classes using both Bootstrap and MediaLinks ### 📊 Changes **4 files changed** (+58 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `src/Markdig.Tests/Specs/MediaSpecs.generated.cs` (+13 -13) 📝 `src/Markdig.Tests/Specs/MediaSpecs.md` (+11 -11) 📝 `src/Markdig.Tests/TestMediaLinks.cs` (+28 -11) 📝 `src/Markdig/Extensions/MediaLinks/MediaLinkExtension.cs` (+6 -6) </details> ### 📄 Description I noticed this when using both the Bootstrap extension and the Media Links extension. When Bootstraps adds `img-fluid`, the Media Link extension didn't add their classes as well. This PR should fix that. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 14:48:55 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
extension
Hacktoberfest
invalid
PR Welcome!
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#1034
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?