[PR #466] Bring back net45 target #1046

Open
opened 2026-01-29 14:49:01 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/xoofx/markdig/pull/466

State: closed
Merged: Yes


I am the author of Markdig.Wpf and recently support for .NET framework was dropped in Markdig (https://github.com/lunet-io/markdig/pull/416). That is a huge breaking change for me since it means my library cannot be used anymore in traditional WPF appplication (i.e. not using netcore3.1 or later).

I propose to bring back at least net45 support since it doesn't need to many changes (only Array.Empty<T> need special care as of now).

I was also supporting net40 but it seems that it is already a done deal here. It was requested by the Visual Studio setup team since they are using my library (https://github.com/Kryptos-FR/markdig.wpf/issues/25). I have opened a discussion on my own repo to decide what to do for that net40 support (https://github.com/Kryptos-FR/markdig.wpf/issues/41).

Note: net452 is part of Windows 8.1 and will be supported until at least January 2023 (see https://support.microsoft.com/en-sg/lifecycle/search?alpha=Windows%208.1 and https://docs.microsoft.com/en-sg/lifecycle/faq/dotnet-framework#what-is-the-lifecycle-policy-for-different-versions-of-the-net-framework).

**Original Pull Request:** https://github.com/xoofx/markdig/pull/466 **State:** closed **Merged:** Yes --- I am the author of [Markdig.Wpf](https://github.com/Kryptos-FR/markdig.wpf) and recently support for .NET framework was dropped in Markdig (https://github.com/lunet-io/markdig/pull/416). That is a huge breaking change for me since it means my library cannot be used anymore in traditional WPF appplication (i.e. not using netcore3.1 or later). I propose to bring back at least net45 support since it doesn't need to many changes (only `Array.Empty<T>` need special care as of now). I was also supporting net40 but it seems that it is already a done deal here. It was requested by the Visual Studio setup team since they are using my library (https://github.com/Kryptos-FR/markdig.wpf/issues/25). I have opened a discussion on my own repo to decide what to do for that net40 support (https://github.com/Kryptos-FR/markdig.wpf/issues/41). *Note: `net452` is part of Windows 8.1 and will be supported until at least January 2023 (see https://support.microsoft.com/en-sg/lifecycle/search?alpha=Windows%208.1 and https://docs.microsoft.com/en-sg/lifecycle/faq/dotnet-framework#what-is-the-lifecycle-policy-for-different-versions-of-the-net-framework).*
claunia added the pull-request label 2026-01-29 14:49:01 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#1046