[PR #471] [CLOSED] Fix Setext headings in block quotes #1050

New Issue

claunia · 2026-01-29T14:49:07Z

claunia commented

2026-01-29 14:49:07 +00:00

📋 Pull Request Information

Original PR: https://github.com/xoofx/markdig/pull/471
Author: @hamvocke
Created: 8/28/2020
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

38cbf61 add failing test, partial fix for setext headings in blockquotes

📊 Changes

4 files changed (+40 additions, -3 deletions)

View changed files

📝 src/Markdig.Tests/Specs/CommonMark.generated.cs (+24 -1)
📝 src/Markdig.Tests/Specs/CommonMark.md (+14 -0)
📝 src/Markdig/Parsers/ParagraphBlockParser.cs (+1 -1)
📝 src/Markdig/Parsers/ThematicBreakParser.cs (+1 -1)

📄 Description

This PR attempts to fix #465 (spoiler alert: I've introduced another problem).

I've added a new test that makes sure that this markdown

> Hello
> ----
> this is some other text

is parsed as a block quote containing a h2. I made the test pass but introduced another regression around lazy continuations of block quotes. This is quite a head-scratcher for me so I'm getting this out with the failing test, maybe we can start discussing intermediate results and another pair of eyes helps fixing the remaining regression (or making sense of my overall approach)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/xoofx/markdig/pull/471 **Author:** [@hamvocke](https://github.com/hamvocke) **Created:** 8/28/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`38cbf61`](https://github.com/xoofx/markdig/commit/38cbf616b05d686af8e196b27feb690663564fb9) add failing test, partial fix for setext headings in blockquotes ### 📊 Changes **4 files changed** (+40 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/Markdig.Tests/Specs/CommonMark.generated.cs` (+24 -1) 📝 `src/Markdig.Tests/Specs/CommonMark.md` (+14 -0) 📝 `src/Markdig/Parsers/ParagraphBlockParser.cs` (+1 -1) 📝 `src/Markdig/Parsers/ThematicBreakParser.cs` (+1 -1) </details> ### 📄 Description This PR attempts to fix #465 (spoiler alert: I've introduced another problem). I've added a new test that makes sure that this markdown ``` > Hello > ---- > this is some other text ``` is parsed as a block quote containing a `h2`. I made the test pass but introduced another regression around lazy continuations of block quotes. This is quite a head-scratcher for me so I'm getting this out with the failing test, maybe we can start discussing intermediate results and another pair of eyes helps fixing the remaining regression (or making sense of my overall approach) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 14:49:07 +00:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/markdig#1050