starred/markdig
1
0
Fork 0
mirror of https://github.com/xoofx/markdig.git synced 2026-02-03 21:36:36 +00:00
Code Issues 690 Packages Projects Releases 20 Wiki Activity

[PR #548] [MERGED] JiraLinkInlineParser.cs - Make digits in JiraKey's posible #1106

New Issue
Open
opened 2026-01-29 14:49:45 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 14:49:45 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/xoofx/markdig/pull/548
Author: @Mysteryduck001
Created: 5/3/2021
Status: ✅ Merged
Merged: 5/8/2021
Merged by: @xoofx

Base: master ← Head: master

📝 Commits (6)

  • f56b8e6 JiraLinkInlineParser.cs - Make digits in JiraKey's posible
  • a8737e8 JiraLinks.md - add examples with JiraKeys using Digits
  • 3a47a51 JiraLinks.generated.cs - updated tests for JiraLink
  • 8ce6f4d JiraLinks.md - Do not allow a digit to be the first Char of the Key
  • 8aa0948 JiraLinkInlineParser.cs - prevent Jira key's to start with a digit
  • aca0857 JiraLinks.Generated.cs - add test for JiraKey's starting with a digit (not allowed)

📊 Changes

3 files changed (+142 additions, -26 deletions)

View changed files

📝 src/Markdig.Tests/Specs/JiraLinks.generated.cs (+103 -23)
📝 src/Markdig.Tests/Specs/JiraLinks.md (+31 -1)
📝 src/Markdig/Extensions/JiraLinks/JiraLinkInlineParser.cs (+8 -2)

📄 Description

A digit can also be part of the project key for example T3ST is a valid project key and T3ST-123 is thus a valid Jira issue number but it will not be recognized by this tool.
I propose to add an OR IsDigit() check like: 'while (current.IsAlphaUpper() || current.IsDigit())'
Thanks for considering to update.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/xoofx/markdig/pull/548 **Author:** [@Mysteryduck001](https://github.com/Mysteryduck001) **Created:** 5/3/2021 **Status:** ✅ Merged **Merged:** 5/8/2021 **Merged by:** [@xoofx](https://github.com/xoofx) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (6) - [`f56b8e6`](https://github.com/xoofx/markdig/commit/f56b8e6ba75848d7be9c85a2355d70353dc383d1) JiraLinkInlineParser.cs - Make digits in JiraKey's posible - [`a8737e8`](https://github.com/xoofx/markdig/commit/a8737e8481555f5b395906c84707e1205a3ed142) JiraLinks.md - add examples with JiraKeys using Digits - [`3a47a51`](https://github.com/xoofx/markdig/commit/3a47a5115ad102a691d31dae3ad0db9b1914bb8a) JiraLinks.generated.cs - updated tests for JiraLink - [`8ce6f4d`](https://github.com/xoofx/markdig/commit/8ce6f4d9ad1e809d392df3507efc7d2f0023fa5b) JiraLinks.md - Do not allow a digit to be the first Char of the Key - [`8aa0948`](https://github.com/xoofx/markdig/commit/8aa0948b2043fa04099e74da55d4f238a143044e) JiraLinkInlineParser.cs - prevent Jira key's to start with a digit - [`aca0857`](https://github.com/xoofx/markdig/commit/aca085703e4c991242424d036700e19ddf679b25) JiraLinks.Generated.cs - add test for JiraKey's starting with a digit (not allowed) ### 📊 Changes **3 files changed** (+142 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `src/Markdig.Tests/Specs/JiraLinks.generated.cs` (+103 -23) 📝 `src/Markdig.Tests/Specs/JiraLinks.md` (+31 -1) 📝 `src/Markdig/Extensions/JiraLinks/JiraLinkInlineParser.cs` (+8 -2) </details> ### 📄 Description A digit can also be part of the project key for example T3ST is a valid project key and T3ST-123 is thus a valid Jira issue number but it will not be recognized by this tool. I propose to add an OR IsDigit() check like: 'while (current.IsAlphaUpper() || current.IsDigit())' Thanks for considering to update. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 14:49:46 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
extension
Hacktoberfest
invalid
PR Welcome!
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#1106
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?