starred/markdig
1
0
Fork 0
mirror of https://github.com/xoofx/markdig.git synced 2026-02-13 13:54:56 +00:00
Code Issues 690 Packages Projects Releases 21 Wiki Activity

[PR #687] [CLOSED] Add support for preserving original label in footnotes & omit back links (fixes issue #684) #1179

New Issue
Open
opened 2026-01-29 14:50:58 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 14:50:58 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/xoofx/markdig/pull/687
Author: @omer-iqbal
Created: 12/17/2022
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (3)

  • 15b2395 Added support for preserving original labels in footnotes
  • 959be3a Added support for preserving original labels in footnotes
  • f0a8968 Change the OmitBackLink property name to CreateBackLinks for better readability.

📊 Changes

13 files changed (+631 additions, -54 deletions)

View changed files

📝 src/Markdig.Tests/Markdig.Tests.csproj (+2 -0)
➕ src/Markdig.Tests/Specs/FootnotesLabelNoBackLinkSpecs.generated.cs (+125 -0)
➕ src/Markdig.Tests/Specs/FootnotesLabelNoBacklinkSpecs.md (+94 -0)
➕ src/Markdig.Tests/Specs/FootnotesLabelSpecs.generated.cs (+125 -0)
➕ src/Markdig.Tests/Specs/FootnotesLabelSpecs.md (+94 -0)
📝 src/Markdig.Tests/Specs/GridTableSpecs.generated.cs (+22 -19)
📝 src/Markdig/Extensions/Footnotes/FootnoteExtension.cs (+16 -3)
➕ src/Markdig/Extensions/Footnotes/FootnoteLabelType.cs (+22 -0)
➕ src/Markdig/Extensions/Footnotes/FootnoteOptions.cs (+53 -0)
📝 src/Markdig/Extensions/Footnotes/HtmlFootnoteGroupRenderer.cs (+6 -2)
📝 src/Markdig/Extensions/Footnotes/HtmlFootnoteLinkRenderer.cs (+13 -4)
📝 src/Markdig/MarkdownExtensions.cs (+31 -0)
📝 src/SpecFileGen/Program.cs (+28 -26)

📄 Description

  1. Added support for preserving original labels in the footnotes
  2. Added an option to not add back links in the footnotes
  3. As a side effect of generating specs, comments in GridTableSpec are also updated

This will resolve issue #684.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/xoofx/markdig/pull/687 **Author:** [@omer-iqbal](https://github.com/omer-iqbal) **Created:** 12/17/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`15b2395`](https://github.com/xoofx/markdig/commit/15b2395b34c8a2fa69ee905e1c9e027fee5dfe22) Added support for preserving original labels in footnotes - [`959be3a`](https://github.com/xoofx/markdig/commit/959be3ad8e83520d503c757dc05c46c90dda4df8) Added support for preserving original labels in footnotes - [`f0a8968`](https://github.com/xoofx/markdig/commit/f0a89686e912246c72b69a48c747237af7a7f518) Change the OmitBackLink property name to CreateBackLinks for better readability. ### 📊 Changes **13 files changed** (+631 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `src/Markdig.Tests/Markdig.Tests.csproj` (+2 -0) ➕ `src/Markdig.Tests/Specs/FootnotesLabelNoBackLinkSpecs.generated.cs` (+125 -0) ➕ `src/Markdig.Tests/Specs/FootnotesLabelNoBacklinkSpecs.md` (+94 -0) ➕ `src/Markdig.Tests/Specs/FootnotesLabelSpecs.generated.cs` (+125 -0) ➕ `src/Markdig.Tests/Specs/FootnotesLabelSpecs.md` (+94 -0) 📝 `src/Markdig.Tests/Specs/GridTableSpecs.generated.cs` (+22 -19) 📝 `src/Markdig/Extensions/Footnotes/FootnoteExtension.cs` (+16 -3) ➕ `src/Markdig/Extensions/Footnotes/FootnoteLabelType.cs` (+22 -0) ➕ `src/Markdig/Extensions/Footnotes/FootnoteOptions.cs` (+53 -0) 📝 `src/Markdig/Extensions/Footnotes/HtmlFootnoteGroupRenderer.cs` (+6 -2) 📝 `src/Markdig/Extensions/Footnotes/HtmlFootnoteLinkRenderer.cs` (+13 -4) 📝 `src/Markdig/MarkdownExtensions.cs` (+31 -0) 📝 `src/SpecFileGen/Program.cs` (+28 -26) </details> ### 📄 Description 1. Added support for preserving original labels in the footnotes 2. Added an option to not add back links in the footnotes 3. As a side effect of generating specs, comments in GridTableSpec are also updated This will resolve issue #684. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 14:50:58 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
extension
Hacktoberfest
invalid
PR Welcome!
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#1179
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?