starred/markdig
1
0
Fork 0
mirror of https://github.com/xoofx/markdig.git synced 2026-02-14 13:54:55 +00:00
Code Issues 690 Packages Projects Releases 21 Wiki Activity

[PR #696] [MERGED] Fix incorrect setext heading source span #1186

New Issue
Open
opened 2026-01-29 14:51:07 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 14:51:07 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/xoofx/markdig/pull/696
Author: @artempyanykh
Created: 2/11/2023
Status: ✅ Merged
Merged: 2/16/2023
Merged by: @xoofx

Base: master ← Head: fix-setext-span

📝 Commits (1)

  • a6cd283 Fix incorrect setext heading source span

📊 Changes

2 files changed (+15 additions, -4 deletions)

View changed files

📝 src/Markdig.Tests/TestSourcePosition.cs (+14 -3)
📝 src/Markdig/Parsers/ParagraphBlockParser.cs (+1 -1)

📄 Description

Previously, heading's span would be 3-6; where 6 is outside the bounds of the original string.

For the context, the original bug report in Marksman #156 (I use markdig there).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/xoofx/markdig/pull/696 **Author:** [@artempyanykh](https://github.com/artempyanykh) **Created:** 2/11/2023 **Status:** ✅ Merged **Merged:** 2/16/2023 **Merged by:** [@xoofx](https://github.com/xoofx) **Base:** `master` ← **Head:** `fix-setext-span` --- ### 📝 Commits (1) - [`a6cd283`](https://github.com/xoofx/markdig/commit/a6cd28318389b3c53d0c4569024c4fbac167e5f0) Fix incorrect setext heading source span ### 📊 Changes **2 files changed** (+15 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/Markdig.Tests/TestSourcePosition.cs` (+14 -3) 📝 `src/Markdig/Parsers/ParagraphBlockParser.cs` (+1 -1) </details> ### 📄 Description Previously, heading's span would be 3-6; where 6 is outside the bounds of the original string. For the context, the original bug report in Marksman [#156](https://github.com/artempyanykh/marksman/issues/156) (I use markdig there). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 14:51:07 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
extension
Hacktoberfest
invalid
PR Welcome!
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#1186
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?