starred/markdig
1
0
Fork 0
mirror of https://github.com/xoofx/markdig.git synced 2026-02-13 13:54:56 +00:00
Code Issues 690 Packages Projects Releases 21 Wiki Activity

[PR #692] [CLOSED] chore: Remove .net452 as it is unsupported #1187

New Issue
Open
opened 2026-01-29 14:51:08 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 14:51:08 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/xoofx/markdig/pull/692
Author: @linkdotnet
Created: 1/14/2023
Status: ❌ Closed

Base: master ← Head: feat/drop-net452

📝 Commits (2)

  • 4030d31 chore: Remove .net452 as it is unsupported
  • e346d7f chore: use using

📊 Changes

10 files changed (+43 additions, -80 deletions)

View changed files

📝 src/Markdig.Tests/Specs/GridTableSpecs.generated.cs (+22 -19)
📝 src/Markdig.Tests/TestDescendantsOrder.cs (+13 -13)
➖ src/Markdig/Helpers/ArrayHelper.cs (+0 -26)
📝 src/Markdig/Helpers/FastStringWriter.cs (+0 -4)
📝 src/Markdig/Markdig.targets (+1 -7)
📝 src/Markdig/Polyfills/ConcurrentQueue.cs (+1 -1)
📝 src/Markdig/Syntax/ContainerBlock.cs (+1 -1)
📝 src/Markdig/Syntax/Inlines/ContainerInline.cs (+1 -1)
📝 src/Markdig/Syntax/LinkReferenceDefinitionGroup.cs (+1 -5)
📝 src/Markdig/Syntax/MarkdownObjectExtensions.cs (+3 -3)

📄 Description

This PR removes the support for .net452, which has been unsupported since April 2022.

There was also a comment in the targets-file:

Markdig.Wpf still supports net452, a target still supported by by Microsoft until January 10, 2023

I guess we are also past that date.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/xoofx/markdig/pull/692 **Author:** [@linkdotnet](https://github.com/linkdotnet) **Created:** 1/14/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feat/drop-net452` --- ### 📝 Commits (2) - [`4030d31`](https://github.com/xoofx/markdig/commit/4030d31db16d4b997787810aa0f72c253c7e45b8) chore: Remove .net452 as it is unsupported - [`e346d7f`](https://github.com/xoofx/markdig/commit/e346d7ffa5cec72461cdf334d3f4312d8fdb367b) chore: use using ### 📊 Changes **10 files changed** (+43 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `src/Markdig.Tests/Specs/GridTableSpecs.generated.cs` (+22 -19) 📝 `src/Markdig.Tests/TestDescendantsOrder.cs` (+13 -13) ➖ `src/Markdig/Helpers/ArrayHelper.cs` (+0 -26) 📝 `src/Markdig/Helpers/FastStringWriter.cs` (+0 -4) 📝 `src/Markdig/Markdig.targets` (+1 -7) 📝 `src/Markdig/Polyfills/ConcurrentQueue.cs` (+1 -1) 📝 `src/Markdig/Syntax/ContainerBlock.cs` (+1 -1) 📝 `src/Markdig/Syntax/Inlines/ContainerInline.cs` (+1 -1) 📝 `src/Markdig/Syntax/LinkReferenceDefinitionGroup.cs` (+1 -5) 📝 `src/Markdig/Syntax/MarkdownObjectExtensions.cs` (+3 -3) </details> ### 📄 Description This PR removes the support for `.net452`, which has been unsupported since [April 2022](https://devblogs.microsoft.com/dotnet/net-framework-4-5-2-4-6-4-6-1-will-reach-end-of-support-on-april-26-2022/). There was also a comment in the targets-file: > Markdig.Wpf still supports net452, a target still supported by by Microsoft until January 10, 2023 I guess we are also past that date. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 14:51:08 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
extension
Hacktoberfest
invalid
PR Welcome!
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#1187
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?