starred/markdig
1
0
Fork 0
mirror of https://github.com/xoofx/markdig.git synced 2026-02-03 21:36:36 +00:00
Code Issues 690 Packages Projects Releases 20 Wiki Activity

[PR #693] [MERGED] Enable ImplictUsings and use file-scoped namespaces #1188

New Issue
Closed
opened 2026-01-29 14:51:09 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 14:51:09 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/xoofx/markdig/pull/693
Author: @iamcarbon
Created: 1/19/2023
Status: ✅ Merged
Merged: 1/24/2023
Merged by: @xoofx

Base: master ← Head: fsn2

📝 Commits (8)

  • 7ef2959 [Tests] Enable ImplictUsings and use file-scoped namespaces
  • 4660426 [WebApp] Enable ImplictUsings and use file-scoped namespaces
  • ca03b7d [Benchmarks] Enable ImplictUsings and use file-scoped namespaces
  • 9693421 [SpecFileGen] Enable ImplictUsings and use file-scoped namespaces
  • a18d8de [UnicodeNormDApp] Enable ImplictUsings and use file-scoped namespaces
  • 66aaffa [mctoc] Enable ImplictUsings and use file-scoped namespaces
  • 74f978e [Markdig] Use file-scoped namespaces
  • 9422764 [Markdig] Use global usings

📊 Changes

363 files changed (+32086 additions, -32669 deletions)

View changed files

📝 src/Markdig.Benchmarks/CommonMarkLib.cs (+22 -24)
📝 src/Markdig.Benchmarks/Markdig.Benchmarks.csproj (+1 -0)
📝 src/Markdig.Benchmarks/Program.cs (+56 -57)
📝 src/Markdig.Benchmarks/TestMatchPerf.cs (+54 -56)
📝 src/Markdig.Benchmarks/TestStringPerf.cs (+45 -46)
📝 src/Markdig.Tests/Markdig.Tests.csproj (+5 -0)
📝 src/Markdig.Tests/MiscTests.cs (+207 -209)
📝 src/Markdig.Tests/Program.cs (+7 -10)
📝 src/Markdig.Tests/RoundtripSpecs/TestAtxHeading.cs (+42 -44)
📝 src/Markdig.Tests/RoundtripSpecs/TestFencedCodeBlock.cs (+89 -91)
📝 src/Markdig.Tests/RoundtripSpecs/TestHtmlBlock.cs (+12 -14)
📝 src/Markdig.Tests/RoundtripSpecs/TestIndentedCodeBlock.cs (+66 -68)
📝 src/Markdig.Tests/RoundtripSpecs/TestLinkReferenceDefinition.cs (+206 -208)
📝 src/Markdig.Tests/RoundtripSpecs/TestNoBlocksFoundBlock.cs (+15 -17)
📝 src/Markdig.Tests/RoundtripSpecs/TestOrderedList.cs (+183 -185)
📝 src/Markdig.Tests/RoundtripSpecs/TestParagraph.cs (+239 -241)
📝 src/Markdig.Tests/RoundtripSpecs/TestQuoteBlock.cs (+251 -253)
📝 src/Markdig.Tests/RoundtripSpecs/TestSetextHeading.cs (+40 -42)
📝 src/Markdig.Tests/RoundtripSpecs/TestThematicBreak.cs (+41 -43)
📝 src/Markdig.Tests/RoundtripSpecs/TestUnorderedList.cs (+175 -177)

...and 80 more files

📄 Description

This PR is up for feedback on whether we should enable file-scoped namespaces on some of all of the markdig projects.

Pulling the indentation in 4 lines on the tests is a fairly nice improvement for readability -- particularly on a 15" laptop.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/xoofx/markdig/pull/693 **Author:** [@iamcarbon](https://github.com/iamcarbon) **Created:** 1/19/2023 **Status:** ✅ Merged **Merged:** 1/24/2023 **Merged by:** [@xoofx](https://github.com/xoofx) **Base:** `master` ← **Head:** `fsn2` --- ### 📝 Commits (8) - [`7ef2959`](https://github.com/xoofx/markdig/commit/7ef2959d6e240d486f273bcb5ed6396ef47f4af8) [Tests] Enable ImplictUsings and use file-scoped namespaces - [`4660426`](https://github.com/xoofx/markdig/commit/46604267194b2ce4e23c7cbc551714ec8db2de95) [WebApp] Enable ImplictUsings and use file-scoped namespaces - [`ca03b7d`](https://github.com/xoofx/markdig/commit/ca03b7df4f6df1309a149a3503fc1e8d3245c083) [Benchmarks] Enable ImplictUsings and use file-scoped namespaces - [`9693421`](https://github.com/xoofx/markdig/commit/96934214db002c61657184830bd050930f634409) [SpecFileGen] Enable ImplictUsings and use file-scoped namespaces - [`a18d8de`](https://github.com/xoofx/markdig/commit/a18d8dee4fee98a8777b2542eb7385bae752af20) [UnicodeNormDApp] Enable ImplictUsings and use file-scoped namespaces - [`66aaffa`](https://github.com/xoofx/markdig/commit/66aaffaef1c9c6af5e7f8d382745dd0051dabffd) [mctoc] Enable ImplictUsings and use file-scoped namespaces - [`74f978e`](https://github.com/xoofx/markdig/commit/74f978ed2dbebff96162d31e6b9193bae6dd6048) [Markdig] Use file-scoped namespaces - [`9422764`](https://github.com/xoofx/markdig/commit/9422764f980e071c2b51120fa38d09f724f83765) [Markdig] Use global usings ### 📊 Changes **363 files changed** (+32086 additions, -32669 deletions) <details> <summary>View changed files</summary> 📝 `src/Markdig.Benchmarks/CommonMarkLib.cs` (+22 -24) 📝 `src/Markdig.Benchmarks/Markdig.Benchmarks.csproj` (+1 -0) 📝 `src/Markdig.Benchmarks/Program.cs` (+56 -57) 📝 `src/Markdig.Benchmarks/TestMatchPerf.cs` (+54 -56) 📝 `src/Markdig.Benchmarks/TestStringPerf.cs` (+45 -46) 📝 `src/Markdig.Tests/Markdig.Tests.csproj` (+5 -0) 📝 `src/Markdig.Tests/MiscTests.cs` (+207 -209) 📝 `src/Markdig.Tests/Program.cs` (+7 -10) 📝 `src/Markdig.Tests/RoundtripSpecs/TestAtxHeading.cs` (+42 -44) 📝 `src/Markdig.Tests/RoundtripSpecs/TestFencedCodeBlock.cs` (+89 -91) 📝 `src/Markdig.Tests/RoundtripSpecs/TestHtmlBlock.cs` (+12 -14) 📝 `src/Markdig.Tests/RoundtripSpecs/TestIndentedCodeBlock.cs` (+66 -68) 📝 `src/Markdig.Tests/RoundtripSpecs/TestLinkReferenceDefinition.cs` (+206 -208) 📝 `src/Markdig.Tests/RoundtripSpecs/TestNoBlocksFoundBlock.cs` (+15 -17) 📝 `src/Markdig.Tests/RoundtripSpecs/TestOrderedList.cs` (+183 -185) 📝 `src/Markdig.Tests/RoundtripSpecs/TestParagraph.cs` (+239 -241) 📝 `src/Markdig.Tests/RoundtripSpecs/TestQuoteBlock.cs` (+251 -253) 📝 `src/Markdig.Tests/RoundtripSpecs/TestSetextHeading.cs` (+40 -42) 📝 `src/Markdig.Tests/RoundtripSpecs/TestThematicBreak.cs` (+41 -43) 📝 `src/Markdig.Tests/RoundtripSpecs/TestUnorderedList.cs` (+175 -177) _...and 80 more files_ </details> ### 📄 Description This PR is up for feedback on whether we should enable file-scoped namespaces on some of all of the markdig projects. Pulling the indentation in 4 lines on the tests is a fairly nice improvement for readability -- particularly on a 15" laptop. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 14:51:09 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
extension
Hacktoberfest
invalid
PR Welcome!
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#1188
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?