starred/markdig
1
0
Fork 0
mirror of https://github.com/xoofx/markdig.git synced 2026-02-03 21:36:36 +00:00
Code Issues 690 Packages Projects Releases 20 Wiki Activity

[PR #736] [MERGED] Better literal delimiter content string slice #1206

New Issue
Closed
opened 2026-01-29 14:51:23 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 14:51:23 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/xoofx/markdig/pull/736
Author: @zickb
Created: 8/30/2023
Status: ✅ Merged
Merged: 8/30/2023
Merged by: @xoofx

Base: master ← Head: better_literal_delimiter_content_string_slice

📝 Commits (4)

  • 06eb6ba Better content string slice of delimiter literals:
  • ccb75fd Merge branch 'master' into better_literal_delimiter_content_string_slice
  • 6d75eed Don't break external users of the public constructor
  • dba94a2 Add documentation for the new constructor.

📊 Changes

3 files changed (+50 additions, -9 deletions)

View changed files

📝 src/Markdig.Tests/TestEmphasisPlus.cs (+17 -1)
📝 src/Markdig/Parsers/Inlines/EmphasisInlineParser.cs (+8 -6)
📝 src/Markdig/Syntax/Inlines/EmphasisDelimiterInline.cs (+25 -2)

📄 Description

Instead of creating a new StringSlice only containing the delimiter chars, use the provided StringSlice from the match method with an appropriate start and end index.

Marked as draft until it is clear if this change is desired.

Fixes: #735

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/xoofx/markdig/pull/736 **Author:** [@zickb](https://github.com/zickb) **Created:** 8/30/2023 **Status:** ✅ Merged **Merged:** 8/30/2023 **Merged by:** [@xoofx](https://github.com/xoofx) **Base:** `master` ← **Head:** `better_literal_delimiter_content_string_slice` --- ### 📝 Commits (4) - [`06eb6ba`](https://github.com/xoofx/markdig/commit/06eb6ba774b5f96a4446620f194d9d352b511346) Better content string slice of delimiter literals: - [`ccb75fd`](https://github.com/xoofx/markdig/commit/ccb75fd5f0cb923f78f7a15d3228d880f1bd32ef) Merge branch 'master' into better_literal_delimiter_content_string_slice - [`6d75eed`](https://github.com/xoofx/markdig/commit/6d75eed3bb3ec7fd32ad539195a721e7726c896b) Don't break external users of the public constructor - [`dba94a2`](https://github.com/xoofx/markdig/commit/dba94a2371ffbb51dc8c0a68a89289d784b8fc1c) Add documentation for the new constructor. ### 📊 Changes **3 files changed** (+50 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/Markdig.Tests/TestEmphasisPlus.cs` (+17 -1) 📝 `src/Markdig/Parsers/Inlines/EmphasisInlineParser.cs` (+8 -6) 📝 `src/Markdig/Syntax/Inlines/EmphasisDelimiterInline.cs` (+25 -2) </details> ### 📄 Description Instead of creating a new StringSlice only containing the delimiter chars, use the provided StringSlice from the match method with an appropriate start and end index. Marked as draft until it is clear if this change is desired. Fixes: #735 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 14:51:23 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
extension
Hacktoberfest
invalid
PR Welcome!
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#1206
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?