starred/markdig
1
0
Fork 0
mirror of https://github.com/xoofx/markdig.git synced 2026-02-03 21:36:36 +00:00
Code Issues 690 Packages Projects Releases 20 Wiki Activity

[PR #837] [MERGED] Fix errors in LinkHelper and LinkInlineParser. #1245

New Issue
Open
opened 2026-01-29 14:51:59 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 14:51:59 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/xoofx/markdig/pull/837
Author: @snnz
Created: 12/21/2024
Status: ✅ Merged
Merged: 12/27/2024
Merged by: @xoofx

Base: master ← Head: fix-links

📝 Commits (7)

  • c35f7ff Fixed errors in LinkHelper and LinkInlineParser.
  • 90365bf Update src/Markdig/Parsers/Inlines/LinkInlineParser.cs
  • ad0770a Update src/Markdig/Parsers/Inlines/LinkInlineParser.cs
  • 54783b8 Update src/Markdig/Parsers/Inlines/LinkInlineParser.cs
  • 7f604be Update src/Markdig/Parsers/Inlines/LinkInlineParser.cs
  • 90bc15c Update src/Markdig.Tests/TestPlayParser.cs
  • ab8e85b Remove additional condition, since a carriage return constitute a line ending regardless of whether it is followed by a line feed or not.

📊 Changes

4 files changed (+124 additions, -130 deletions)

View changed files

📝 src/Markdig.Tests/TestLinkHelper.cs (+15 -0)
📝 src/Markdig.Tests/TestPlayParser.cs (+8 -0)
📝 src/Markdig/Helpers/LinkHelper.cs (+92 -124)
📝 src/Markdig/Parsers/Inlines/LinkInlineParser.cs (+9 -6)

📄 Description

Here is what I used to fix #830. LinkHelper.TryParseTitle is replaced with more structured and clearer one, check it out.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/xoofx/markdig/pull/837 **Author:** [@snnz](https://github.com/snnz) **Created:** 12/21/2024 **Status:** ✅ Merged **Merged:** 12/27/2024 **Merged by:** [@xoofx](https://github.com/xoofx) **Base:** `master` ← **Head:** `fix-links` --- ### 📝 Commits (7) - [`c35f7ff`](https://github.com/xoofx/markdig/commit/c35f7fff178bddcb4d8165e9f67c97a37d0b912f) Fixed errors in LinkHelper and LinkInlineParser. - [`90365bf`](https://github.com/xoofx/markdig/commit/90365bfeee0e9051992354aacfe35f4350a76c16) Update src/Markdig/Parsers/Inlines/LinkInlineParser.cs - [`ad0770a`](https://github.com/xoofx/markdig/commit/ad0770a59406f432d3de402a93289c6d983d5428) Update src/Markdig/Parsers/Inlines/LinkInlineParser.cs - [`54783b8`](https://github.com/xoofx/markdig/commit/54783b8f65db62a56f6d7b8982566d8922117cd6) Update src/Markdig/Parsers/Inlines/LinkInlineParser.cs - [`7f604be`](https://github.com/xoofx/markdig/commit/7f604bef30746ee35d74d2e65498dcaf2cac384f) Update src/Markdig/Parsers/Inlines/LinkInlineParser.cs - [`90bc15c`](https://github.com/xoofx/markdig/commit/90bc15c016a84c3758374337516c83e5733435b9) Update src/Markdig.Tests/TestPlayParser.cs - [`ab8e85b`](https://github.com/xoofx/markdig/commit/ab8e85b06e87e87c30a7530d0c37c0561921bd95) Remove additional condition, since a carriage return constitute a line ending regardless of whether it is followed by a line feed or not. ### 📊 Changes **4 files changed** (+124 additions, -130 deletions) <details> <summary>View changed files</summary> 📝 `src/Markdig.Tests/TestLinkHelper.cs` (+15 -0) 📝 `src/Markdig.Tests/TestPlayParser.cs` (+8 -0) 📝 `src/Markdig/Helpers/LinkHelper.cs` (+92 -124) 📝 `src/Markdig/Parsers/Inlines/LinkInlineParser.cs` (+9 -6) </details> ### 📄 Description Here is what I used to fix #830. `LinkHelper.TryParseTitle` is replaced with more structured and clearer one, check it out. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 14:51:59 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
extension
Hacktoberfest
invalid
PR Welcome!
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#1245
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?