starred/markdig
1
0
Fork 0
mirror of https://github.com/xoofx/markdig.git synced 2026-02-03 21:36:36 +00:00
Code Issues 690 Packages Projects Releases 20 Wiki Activity

AutoLinks option to open in new window #140

New Issue
Closed
opened 2026-01-29 14:28:31 +00:00 by claunia · 5 comments
claunia commented 2026-01-29 14:28:31 +00:00
Owner
Copy Link

Originally created by @pebezo on GitHub (Sep 20, 2017).

Hi,

I noticed that JiraLinks has this feature, but not AutoLinks. Would you consider a PR for this?

Thanks.

Originally created by @pebezo on GitHub (Sep 20, 2017). Hi, I noticed that JiraLinks has this feature, but not AutoLinks. Would you consider a PR for this? Thanks.
claunia added the enhancementPR Welcome! labels 2026-01-29 14:28:31 +00:00
claunia commented 2026-01-29 14:28:33 +00:00
Author
Owner
Copy Link

@xoofx commented on GitHub (Sep 20, 2017):

sure.

@xoofx commented on GitHub (Sep 20, 2017): sure.
claunia commented 2026-01-29 14:28:33 +00:00
Author
Owner
Copy Link

@pebezo commented on GitHub (Oct 22, 2017):

When I open the solution with VS2015 (it looks like the .sln file was made by VS2015) I cannot load the Markdig project. I get:

Markdig.csproj : error  : The default XML namespace of the project must be the MSBuild XML namespace. If the project is authored in the MSBuild 2003 format, please add xmlns="http://schemas.microsoft.com/developer/msbuild/2003" to the <Project> element. If the project has been authored in the old 1.0 or 1.2 format, please convert it to MSBuild 2003 format.

If I try with VS2017, when compiling Markdig, I get:

Severity	Code	Description	Project	File	Line	Suppression State
Error	APPX3217	SDK folder containing 'UAP.props' for 'UAP 10.0.10240.0' cannot be located. See http://go.microsoft.com/fwlink/?LinkID=798187 for more information.	Markdig	C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\Microsoft\VisualStudio\v15.0\AppxPackage\Microsoft.AppXPackage.Targets	874

Any ideas?

@pebezo commented on GitHub (Oct 22, 2017): When I open the solution with VS2015 (it looks like the .sln file was made by VS2015) I cannot load the Markdig project. I get: ``` Markdig.csproj : error : The default XML namespace of the project must be the MSBuild XML namespace. If the project is authored in the MSBuild 2003 format, please add xmlns="http://schemas.microsoft.com/developer/msbuild/2003" to the <Project> element. If the project has been authored in the old 1.0 or 1.2 format, please convert it to MSBuild 2003 format. ``` If I try with VS2017, when compiling Markdig, I get: ``` Severity Code Description Project File Line Suppression State Error APPX3217 SDK folder containing 'UAP.props' for 'UAP 10.0.10240.0' cannot be located. See http://go.microsoft.com/fwlink/?LinkID=798187 for more information. Markdig C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\Microsoft\VisualStudio\v15.0\AppxPackage\Microsoft.AppXPackage.Targets 874 ``` Any ideas?
claunia commented 2026-01-29 14:28:34 +00:00
Author
Owner
Copy Link

@xoofx commented on GitHub (Oct 22, 2017):

You need most likely to install UWP components (10240) from the Visual Studio 2017 installer. Don't recall exactly the option... I should add a part in the readme about this.

@xoofx commented on GitHub (Oct 22, 2017): You need most likely to install UWP components (10240) from the Visual Studio 2017 installer. Don't recall exactly the option... I should add a part in the readme about this.
claunia commented 2026-01-29 14:28:34 +00:00
Author
Owner
Copy Link

@pebezo commented on GitHub (Oct 22, 2017):

I installed Universal Windows Platform, but Windows 10 SDK (10.0.10240.0) was marked as optional. After checking / installing that option I'm now able to build. Thanks.

@pebezo commented on GitHub (Oct 22, 2017): I installed Universal Windows Platform, but Windows 10 SDK (10.0.10240.0) was marked as optional. After checking / installing that option I'm now able to build. Thanks.
claunia commented 2026-01-29 14:28:34 +00:00
Author
Owner
Copy Link

@pebezo commented on GitHub (Oct 23, 2017):

JiraLinks has the OpenInNewWindow property true by default. As far as I can tell, the tests only check for the true value.

In the case of AutoLink, setting a similar value to true would be a breaking change, so we should probably have it false by default. As far as testing, would you like a clone of AutoLinks.md that has target="blank" or just have hand written tests (i.e. not auto generated from .md files) that would test the new option on AutoLink?

Thanks

@pebezo commented on GitHub (Oct 23, 2017): JiraLinks has the `OpenInNewWindow` property `true` by default. As far as I can tell, the tests only check for the `true` value. In the case of AutoLink, setting a similar value to true would be a breaking change, so we should probably have it `false` by default. As far as testing, would you like a clone of AutoLinks.md that has `target="blank"` or just have hand written tests (i.e. not auto generated from .md files) that would test the new option on AutoLink? Thanks
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
extension
Hacktoberfest
invalid
PR Welcome!
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label enhancement PR Welcome!
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#140
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?