starred/markdig
1
0
Fork 0
mirror of https://github.com/xoofx/markdig.git synced 2026-02-04 05:44:50 +00:00
Code Issues 690 Packages Projects Releases 20 Wiki Activity

LinkReferenceDefinition.Line never assigned #144

New Issue
Closed
opened 2026-01-29 14:28:36 +00:00 by claunia · 3 comments
claunia commented 2026-01-29 14:28:36 +00:00
Owner
Copy Link

Originally created by @labreuer on GitHub (Oct 17, 2017).

I am very interested in markdig tracking the precise source code location for the syntax tree; unfortunately LinkReferenceDefinition.Line never seems set, perhaps because LinkReferenceDefinition is generated from an ICharIterator, which could be a StringSlice, which has no line # information. Was this by design?

If you're ok with LinkReferenceDefinition.TryParse accepting a StringLineGroup.Iterator, that would seem to suffice; it is not currently called with a StringSlice. I'm happy to put together a pull request.

Originally created by @labreuer on GitHub (Oct 17, 2017). I am very interested in markdig tracking the precise source code location for the syntax tree; unfortunately `LinkReferenceDefinition.Line` never seems set, perhaps because `LinkReferenceDefinition` is generated from an `ICharIterator`, which could be a `StringSlice`, which has no line # information. Was this by design? If you're ok with `LinkReferenceDefinition.TryParse` accepting a `StringLineGroup.Iterator`, that would seem to suffice; it is not currently called with a `StringSlice`. I'm happy to put together a pull request.
claunia added the enhancementPR Welcome! labels 2026-01-29 14:28:36 +00:00
claunia commented 2026-01-29 14:28:37 +00:00
Author
Owner
Copy Link

@xoofx commented on GitHub (Oct 17, 2017):

I am very interested in markdig tracking the precise source code location for the syntax tree; unfortunately LinkReferenceDefinition.Line never seems set, perhaps because LinkReferenceDefinition is generated from an ICharIterator, which could be a StringSlice, which has no line # information. Was this by design?

afair no. It's just that line information was added after and a few places could have been missed during the process of adding the spans (I know for example that many extensions are not updated correctly...)

If you're ok with LinkReferenceDefinition.TryParse accepting a StringLineGroup.Iterator, that would seem to suffice; it is not currently called with a StringSlice. I'm happy to put together a pull request.

I don't remember the details, but in LinkReferenceDefinition.TryParse we are already able to output spans for label..etc (via LinkHelper.TryParseLinkReferenceDefinition) so it should be possible to work with this already (as it is only using global Start position from beginning of file so it should be fine...). PR much welcome of course.

@xoofx commented on GitHub (Oct 17, 2017): > I am very interested in markdig tracking the precise source code location for the syntax tree; unfortunately LinkReferenceDefinition.Line never seems set, perhaps because LinkReferenceDefinition is generated from an ICharIterator, which could be a StringSlice, which has no line # information. Was this by design? afair no. It's just that line information was added after and a few places could have been missed during the process of adding the spans (I know for example that many extensions are not updated correctly...) > If you're ok with LinkReferenceDefinition.TryParse accepting a StringLineGroup.Iterator, that would seem to suffice; it is not currently called with a StringSlice. I'm happy to put together a pull request. I don't remember the details, but in `LinkReferenceDefinition.TryParse` we are already able to output spans for label..etc (via `LinkHelper.TryParseLinkReferenceDefinition`) so it should be possible to work with this already (as it is only using global Start position from beginning of file so it should be fine...). PR much welcome of course.
claunia commented 2026-01-29 14:28:38 +00:00
Author
Owner
Copy Link

@MihaZupan commented on GitHub (Jan 18, 2019):

This was fixed by #243

@MihaZupan commented on GitHub (Jan 18, 2019): This was fixed by #243
claunia commented 2026-01-29 14:28:38 +00:00
Author
Owner
Copy Link

@MihaZupan commented on GitHub (Apr 5, 2019):

Closing as resolved

@MihaZupan commented on GitHub (Apr 5, 2019): Closing as resolved
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
extension
Hacktoberfest
invalid
PR Welcome!
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label enhancement PR Welcome!
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#144
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?