starred/markdig
1
0
Fork 0
mirror of https://github.com/xoofx/markdig.git synced 2026-02-03 21:36:36 +00:00
Code Issues 690 Packages Projects Releases 20 Wiki Activity

[Question] TextWriter.NewLine is hard-coded to '\n' even when running on Windows #194

New Issue
Closed
opened 2026-01-29 14:30:05 +00:00 by claunia · 3 comments
claunia commented 2026-01-29 14:30:05 +00:00
Owner
Copy Link

Originally created by @augustoproiete on GitHub (Feb 20, 2018).

Hello!

Quick question: Is there a reason to always uses \n for line-breaks instead of Environment.NewLine, or is just preference?

Markdown files will typically contain fragments of content that - after being converted to HTML - are likely added as content to an HTML template (which itself has line-breaks), which can cause mixed line-endings if the HTML template uses \r\n.

Originally created by @augustoproiete on GitHub (Feb 20, 2018). Hello! Quick question: Is there a reason to [always uses `\n` for line-breaks instead of `Environment.NewLine`](https://github.com/lunet-io/markdig/blob/master/src/Markdig/Renderers/TextRendererBase.cs#L32), or is just preference? Markdown files will typically contain fragments of content that - after being converted to HTML - are likely added as content to an HTML template (which itself has line-breaks), which can cause mixed line-endings if the HTML template uses `\r\n`.
claunia added the enhancementPR Welcome! labels 2026-01-29 14:30:05 +00:00
claunia commented 2026-01-29 14:30:06 +00:00
Author
Owner
Copy Link

@Kryptos-FR commented on GitHub (Feb 20, 2018):

This should probably be an option (with a decent default value, like Environment.NewLine) so as to accommodate all scenarios.

@Kryptos-FR commented on GitHub (Feb 20, 2018): This should probably be an option (with a decent default value, like `Environment.NewLine`) so as to accommodate all scenarios.
claunia commented 2026-01-29 14:30:07 +00:00
Author
Owner
Copy Link

@augustoproiete commented on GitHub (Feb 21, 2018):

@Kryptos-FR I agree that this should be configurable. I've submitted PR #214 to address that.

I'm curious on why Environment.NewLine is not the default, though...

@augustoproiete commented on GitHub (Feb 21, 2018): @Kryptos-FR I agree that this should be configurable. I've submitted PR #214 to address that. I'm curious on why `Environment.NewLine` is not the default, though...
claunia commented 2026-01-29 14:30:07 +00:00
Author
Owner
Copy Link

@xoofx commented on GitHub (Apr 4, 2018):

Thanks, PR #214 is merged, will publish a new package soon

@xoofx commented on GitHub (Apr 4, 2018): Thanks, PR #214 is merged, will publish a new package soon
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
extension
Hacktoberfest
invalid
PR Welcome!
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label enhancement PR Welcome!
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#194
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?