mirror of
https://github.com/xoofx/markdig.git
synced 2026-02-13 05:45:31 +00:00
[Table Extension] Escaped pipe character in code is shown #215
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @yishengjin1413 on GitHub (Jul 10, 2018).
Hi,
We now have a issue that when escaped pipe in code appear in table. Markdig have different behavior with github. I test on babelmark and here is the example:
Markdig result:
x \| yx | yGithub result:
x | yIs it possible for markdig to keep the same behavior with github in this case?
@Kryptos-FR commented on GitHub (Jul 10, 2018):
To me it is actually the GitHub version that is incorrect. Anything inside `` should be verbatim.
Maybe raise a similar issue in the GitHub repository (linking to that one) and let's see what they think of it.
@yishengjin1413 commented on GitHub (Jul 10, 2018):
Thanks @Kryptos-FR for your interesting about this issue. I agree with you. Do you know how to open a public issue to github?
@xoofx commented on GitHub (Jul 10, 2018):
This is a known issue. The previous implementation of tables in Markdown at GitHub was performing a split on the final HTML in order to create the table (!), so they have simply replicated this poor behavior. Unfortunately, they will unlikely change this because they have now a legacy to be compatible with...
This is one question I asked a while ago while implementing tables for markdig, I came with the solution of doing it more properly using the parser information instead of going through text/character split. The GitHub developer behind the new implementation (cmark fork), gave some insights about how they implemented the pipe table
We should probably have an option for GitHub pipe table parser... that would trigger a completely different parser (instead of trying to adapt the current which I would like to kept as it is, as it is more accurate)
@yishengjin1413 commented on GitHub (Jul 11, 2018):
Thanks @xoofx , very useful information. I will keep the markdig behavior for now. I think it's more clear too.