mirror of
https://github.com/xoofx/markdig.git
synced 2026-02-09 13:56:56 +00:00
Empty alt text on reference-style images rendering incorrectly #227
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @guypursey on GitHub (Oct 1, 2018).
Good
This:
Produces this:
Which is expected behaviour and good for accessibility.
Bad
However, if you use a reference style image:
You get this:
Which is not good for accessibility -- there's no reason the alt text should be the number
1.You can try this yourself with Markdig here to verify.
Summary
I'd expect the reference-style image to behave in the same way as the inline-style image notation which is listed as example 552 in the CommonMark spec.
But instead it's using the index of the footnote as the alt text.
Expected behaviour renders in most other libraries and crucially you can see this rendering correctly in CommonMark which Markdig purports to be compliant with.
@xoofx commented on GitHub (Oct 1, 2018):
Bugs happen, PR Welcome.
@xoofx commented on GitHub (Oct 7, 2018):
Fixed by PR #254 by @MihaZupan
@guypursey commented on GitHub (Oct 8, 2018):
Sorry to follow-up on a closed issue, but any idea when the PR above (#254 ) might be included in a release? Thanks.
@xoofx commented on GitHub (Oct 8, 2018):
I don't always push a new release for every PR merged. I wait for a few days/weeks if this is not critical to batch them with other PRs. You can always compile it on your own if you want this immediately.
@guypursey commented on GitHub (Oct 8, 2018):
Thanks @xoofx. Appreciate the quick response.