Autolink does not recognize domain names followed by URL fragments query or port #230

Closed
opened 2026-01-29 14:30:55 +00:00 by claunia · 3 comments
Owner

Originally created by @yufeih on GitHub (Oct 25, 2018).

Due to #253, https://github.com#a, https://github.com?a, https://github.com:443 is no longer recognized as autolink. The spec does not say about requiring a / after domain name, browsers can also handles these types of links just fine.

cc @MihaZupan

Originally created by @yufeih on GitHub (Oct 25, 2018). Due to #253, https://github.com#a, https://github.com?a, https://github.com:443 is no longer recognized as autolink. The [spec](https://github.github.com/gfm/#extended-autolink-path-validation) does not say about requiring a `/` after domain name, browsers can also handles these types of links just fine. cc @MihaZupan
Author
Owner

@MihaZupan commented on GitHub (Oct 25, 2018):

I see, I think the only change needed here is to check for these characters along with the '/' check in LinkHelper. I'll do a PR when I get to a computer.

@MihaZupan commented on GitHub (Oct 25, 2018): I see, I think the only change needed here is to check for these characters along with the '/' check in LinkHelper. I'll do a PR when I get to a computer.
Author
Owner

@xoofx commented on GitHub (Oct 29, 2018):

Fixed by PR #260

@xoofx commented on GitHub (Oct 29, 2018): Fixed by PR #260
Author
Owner

@yufeih commented on GitHub (Oct 30, 2018):

Thank you guys for the fix, awesome 🎁

@yufeih commented on GitHub (Oct 30, 2018): Thank you guys for the fix, awesome 🎁
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#230