Is AutolinkInline obsolete? #236

Closed
opened 2026-01-29 14:31:03 +00:00 by claunia · 5 comments
Owner

Originally created by @Kryptos-FR on GitHub (Oct 27, 2018).

When using markdig, in my WPF renderer, if I enable the autolink extension, I always get the links through a LinkInline and never through an AutolinkInline.

Should I remove the autolink-specific renderer?

If the autolinkInline is not be used anymore, maybe it would be nice to add the [Obsolete] attribute. But I might also be missing some other uses that I don't know about.

Originally created by @Kryptos-FR on GitHub (Oct 27, 2018). When using markdig, in my WPF renderer, if I enable the autolink extension, I always get the links through a `LinkInline` and never through an `AutolinkInline`. Should I remove the autolink-specific renderer? If the autolinkInline is not be used anymore, maybe it would be nice to add the `[Obsolete]` attribute. But I might also be missing some other uses that I don't know about.
claunia added the question label 2026-01-29 14:31:03 +00:00
Author
Owner

@xoofx commented on GitHub (Oct 29, 2018):

Good question, I will have to take a look at this, don't remember much about the codebase for this part actually 😅

@xoofx commented on GitHub (Oct 29, 2018): Good question, I will have to take a look at this, don't remember much about the codebase for this part actually 😅
Author
Owner

@Kryptos-FR commented on GitHub (Oct 29, 2018):

It kinds of breaks it for email that are not recognized as such anymore.

@Kryptos-FR commented on GitHub (Oct 29, 2018): It kinds of breaks it for email that are not recognized as such anymore.
Author
Owner

@MihaZupan commented on GitHub (Oct 31, 2018):

The naming might be confusing, but AutolinkInline is not what the AutoLink extension emits.

Autolinks are absolute URIs and email addresses inside < and >. They are parsed as links, with the URL or email address as the link label.

Autolinks can also be constructed without requiring the use of < and to > to delimit them, although they will be recognized under a smaller set of circumstances.

The first one is handeled by AutolineInlineParser, the second case by the AutoLink extension (AutoLinkParser).

AutolinkInline is used for <url> syntax only, while LinkInline is used for others.

I'm not sure if "AutolineInlineParser" was a typo.

@MihaZupan commented on GitHub (Oct 31, 2018): The naming might be confusing, but AutolinkInline is not what the AutoLink extension emits. > Autolinks are absolute URIs and email addresses inside < and >. They are parsed as links, with the URL or email address as the link label. > Autolinks can also be constructed without requiring the use of < and to > to delimit them, although they will be recognized under a smaller set of circumstances. The first one is handeled by `AutolineInlineParser`, the second case by the AutoLink extension (`AutoLinkParser`). AutolinkInline is used for `<url>` syntax only, while LinkInline is used for others. I'm not sure if "AutolineInlineParser" was a typo.
Author
Owner

@xoofx commented on GitHub (Oct 31, 2018):

Yeah, it's a typo AutolineInlineParser 😅

I don't remember why I didn't use AutoLinkInline instead for the autolink extension. I haven't had the time to check the code base about this....

@xoofx commented on GitHub (Oct 31, 2018): Yeah, it's a typo `AutolineInlineParser` 😅 I don't remember why I didn't use `AutoLinkInline` instead for the autolink extension. I haven't had the time to check the code base about this....
Author
Owner

@Kryptos-FR commented on GitHub (Oct 31, 2018):

OK. I'll keep both renderers and make sure they behave consistently.
Thanks for the explanation.

@Kryptos-FR commented on GitHub (Oct 31, 2018): OK. I'll keep both renderers and make sure they behave consistently. Thanks for the explanation.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#236