mirror of
https://github.com/xoofx/markdig.git
synced 2026-02-03 21:36:36 +00:00
Is AutolinkInline obsolete? #236
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Kryptos-FR on GitHub (Oct 27, 2018).
When using markdig, in my WPF renderer, if I enable the autolink extension, I always get the links through a
LinkInlineand never through anAutolinkInline.Should I remove the autolink-specific renderer?
If the autolinkInline is not be used anymore, maybe it would be nice to add the
[Obsolete]attribute. But I might also be missing some other uses that I don't know about.@xoofx commented on GitHub (Oct 29, 2018):
Good question, I will have to take a look at this, don't remember much about the codebase for this part actually 😅
@Kryptos-FR commented on GitHub (Oct 29, 2018):
It kinds of breaks it for email that are not recognized as such anymore.
@MihaZupan commented on GitHub (Oct 31, 2018):
The naming might be confusing, but AutolinkInline is not what the AutoLink extension emits.
The first one is handeled by
AutolineInlineParser, the second case by the AutoLink extension (AutoLinkParser).AutolinkInline is used for
<url>syntax only, while LinkInline is used for others.I'm not sure if "AutolineInlineParser" was a typo.
@xoofx commented on GitHub (Oct 31, 2018):
Yeah, it's a typo
AutolineInlineParser😅I don't remember why I didn't use
AutoLinkInlineinstead for the autolink extension. I haven't had the time to check the code base about this....@Kryptos-FR commented on GitHub (Oct 31, 2018):
OK. I'll keep both renderers and make sure they behave consistently.
Thanks for the explanation.