starred/markdig
1
0
Fork 0
mirror of https://github.com/xoofx/markdig.git synced 2026-02-13 21:42:57 +00:00
Code Issues 690 Packages Projects Releases 21 Wiki Activity

TextMatchHelper was removed — what's upgrade path? #275

New Issue
Closed
opened 2026-01-29 14:32:31 +00:00 by claunia · 2 comments
claunia commented 2026-01-29 14:32:31 +00:00
Owner
Copy Link

Originally created by @leotsarev on GitHub (Feb 26, 2019).

TextMatchHelper was removed in #305 by @MihaZupan
It was useful for my private extension https://github.com/joinrpg/joinrpg-net/blob/master/Joinrpg.Markdown/LinkerParser.cs
new CompactPrefixTree is internal api, and I couldn't use it and benefit from wonderful optimizations.
Could you please make it public and/or introduce another public surface for the use case?

For now, I just copied TextMatchHelper into my code.

Originally created by @leotsarev on GitHub (Feb 26, 2019). TextMatchHelper was removed in #305 by @MihaZupan It was useful for my private extension https://github.com/joinrpg/joinrpg-net/blob/master/Joinrpg.Markdown/LinkerParser.cs new CompactPrefixTree is internal api, and I couldn't use it and benefit from wonderful optimizations. Could you please make it public and/or introduce another public surface for the use case? For now, I just copied TextMatchHelper into my code.
claunia added the question label 2026-01-29 14:32:31 +00:00
claunia commented 2026-01-29 14:32:32 +00:00
Author
Owner
Copy Link

@xoofx commented on GitHub (Feb 26, 2019):

Yes, it was not meant originally to be public but forgot to remove it. There are a couple of API that will be removed from the surface API (from the Helpers namespace for instance)

If you are looking for this API, I suggest you to use directly https://github.com/MihaZupan/SharpCollections from @MihaZupan

@xoofx commented on GitHub (Feb 26, 2019): Yes, it was not meant originally to be public but forgot to remove it. There are a couple of API that will be removed from the surface API (from the Helpers namespace for instance) If you are looking for this API, I suggest you to use directly https://github.com/MihaZupan/SharpCollections from @MihaZupan
claunia commented 2026-01-29 14:32:33 +00:00
Author
Owner
Copy Link

@leotsarev commented on GitHub (Feb 26, 2019):

From my point of view, it was nice convenience api from extensions :-(
But I'll live with that decision

@leotsarev commented on GitHub (Feb 26, 2019): From my point of view, it was nice convenience api from extensions :-( But I'll live with that decision
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
extension
Hacktoberfest
invalid
PR Welcome!
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label question
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#275
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?