Make pipeline deep immutable #285

New Issue

claunia · 2026-01-29T14:32:47Z

claunia commented

2026-01-29 14:32:47 +00:00

Originally created by @xoofx on GitHub (Apr 5, 2019).

Today, options pushed from a user to parsers but also directly parser instance (which are less directly exposed to users) can be modified during the process of request.

The work on making the markdown pipeline thread/safe immutable was only valid for the list part of the extensions ( #5 ), but is not really valid for some classes that are shared and can be modified during the process of a pipeline.

We need to figure out what we want to do with that.

Likely, we will have to make all these classes immutable - which will require painful constructors...etc.

(See for example comment on PR 327 )

Originally created by @xoofx on GitHub (Apr 5, 2019). Today, options pushed from a user to parsers but also directly parser instance (which are less directly exposed to users) can be modified during the process of request. The work on making the markdown pipeline thread/safe immutable was only valid for the list part of the extensions ( #5 ), but is not really valid for some classes that are shared and can be modified during the process of a pipeline. We need to figure out what we want to do with that. Likely, we will have to make all these classes immutable - which will require painful constructors...etc. (See for example [comment on PR 327](https://github.com/lunet-io/markdig/pull/327#pullrequestreview-223355552) )

claunia added the enhancement label 2026-01-29 14:32:47 +00:00

claunia commented

2026-01-29 14:32:48 +00:00

@MihaZupan commented on GitHub (Apr 5, 2019):

An internal Clone() method could be added to *Option classes.

For the cases where properties are not collections (only bools, strings), it could be simply implemented as

internal AutoLinkOptions Clone() => MemberwiseClone() as AutoLinkOptions;

And then have that be used by the extension like

private readonly AutoLinkOptions _options;

public AutoLinkExtension(AutoLinkOptions options)
{
    _options = options?.Clone() ?? new AutoLinkOptions();
}

@MihaZupan commented on GitHub (Apr 5, 2019): An internal `Clone()` method could be added to `*Option` classes. For the cases where properties are not collections (only bools, strings), it could be simply implemented as ```csharp internal AutoLinkOptions Clone() => MemberwiseClone() as AutoLinkOptions; ``` And then have that be used by the extension like ```csharp private readonly AutoLinkOptions _options; public AutoLinkExtension(AutoLinkOptions options) { _options = options?.Clone() ?? new AutoLinkOptions(); } ```

claunia referenced this issue

2026-01-29 14:47:09 +00:00

[PR #285] [MERGED] Adds markdown parser context #911

claunia referenced this issue

2026-01-29 14:47:12 +00:00

[PR #285] Adds markdown parser context #916

Sign in to join this conversation.