starred/markdig
1
0
Fork 0
mirror of https://github.com/xoofx/markdig.git synced 2026-02-09 13:56:56 +00:00
Code Issues 690 Packages Projects Releases 20 Wiki Activity

LinkHelper.Urilize #36

New Issue
Closed
opened 2026-01-29 14:22:05 +00:00 by claunia · 3 comments
claunia commented 2026-01-29 14:22:05 +00:00
Owner
Copy Link

Originally created by @Jither on GitHub (Jun 26, 2016).

Tiny oversight in LinkHelper.Urilize - it throws out any and all digits. The easy fix:

LinkHelper.cs, Line 64 in current revision, insert:

else if (c.IsDigit())
{
    headingBuffer.Append(c);
    previousIsSpace = false;
}

And a few complimentary, non-exhaustive, tests. A few of them have a comment about not being equivalent to what Pandoc does (it doesn't trim trailing special chars). No-one says they have to be, though. 😃

[TestCase("Header identifiers in HTML", "header-identifiers-in-html")]
[TestCase("* Dogs*?--in *my* house?"  , "dogs-in-my-house")] // Not Pandoc equivalent: dogs--in...
[TestCase("[HTML], [S5], or [RTF]?"   , "html-s5-or-rtf")]
[TestCase("3. Applications"           , "applications")]
[TestCase("33"                        , "")]
public void TestUrilizeNonAscii_Pandoc(string input, string expectedResult)
{
    Assert.AreEqual(expectedResult, LinkHelper.Urilize(input, false));
}

[TestCase("abc" , "abc")]
[TestCase("a-c" , "a-c")]
[TestCase("a c" , "a-c")]
[TestCase("a_c" , "a_c")]
[TestCase("a.c" , "a.c")]
[TestCase("a,c" , "ac")]
[TestCase("a--" , "a")] // Not Pandoc-equivalent: a--
[TestCase("a__" , "a")] // Not Pandoc-equivalent: a__
[TestCase("a.." , "a")] // Not Pandoc-equivalent: a..
[TestCase("a??" , "a")]
[TestCase("a  " , "a")]
[TestCase("a--d", "a-d")]
[TestCase("a__d", "a_d")]
[TestCase("a??d", "ad")]
[TestCase("a  d", "a-d")]
[TestCase("a..d", "a..d")]
[TestCase("-bc" , "bc")]
[TestCase("_bc" , "bc")]
[TestCase(" bc" , "bc")]
[TestCase("?bc" , "bc")]
[TestCase(".bc" , "bc")]
[TestCase("a-.-", "a")] // Not Pandoc equivalent: a-.-
public void TestUrilizeOnlyAscii_Simple(string input, string expectedResult)
{
    Assert.AreEqual(expectedResult, LinkHelper.Urilize(input, true));
}

[TestCase("bær", "br")]
[TestCase("bør", "br")]
[TestCase("bΘr", "br")]
[TestCase("四五", "")]
public void TestUrilizeOnlyAscii_NonAscii(string input, string expectedResult)
{
    Assert.AreEqual(expectedResult, LinkHelper.Urilize(input, true));
}

[TestCase("bár"   , "bar")]
[TestCase("àrrivé", "arrive")]
public void TestUrilizeOnlyAscii_Normalization(string input, string expectedResult)
{
    Assert.AreEqual(expectedResult, LinkHelper.Urilize(input, true));
}

[TestCase("123"  , "")]
[TestCase("1,-b" , "b")]
[TestCase("b1,-" , "b1")] // Not Pandoc equivalent: b1-
[TestCase("ab3"  , "ab3")]
[TestCase("ab3de", "ab3de")]
public void TestUrilizeOnlyAscii_Numeric(string input, string expectedResult)
{
    Assert.AreEqual(expectedResult, LinkHelper.Urilize(input, true));
}

[TestCase("一二三四五", "一二三四五")]
[TestCase("一,-b"    , "一-b")]
public void TestUrilizeNonAscii_NonAsciiNumeric(string input, string expectedResult)
{
    Assert.AreEqual(expectedResult, LinkHelper.Urilize(input, false));
}

[TestCase("bær"  , "bær")]
[TestCase("æ5el" , "æ5el")]
[TestCase("-æ5el", "æ5el")]
[TestCase("-frø-", "frø")]
[TestCase("-fr-ø", "fr-ø")]
public void TestUrilizeNonAscii_Simple(string input, string expectedResult)
{
    Assert.AreEqual(expectedResult, LinkHelper.Urilize(input, false));
}

// Just to be sure, test for characters expressly forbidden in URI fragments:
[TestCase("b#r"  , "br")]
[TestCase("b%r"  , "br")] // Invalid except as an escape character
[TestCase("b^r"  , "br")]
[TestCase("b[r"  , "br")]
[TestCase("b]r"  , "br")]
[TestCase("b{r"  , "br")]
[TestCase("b}r"  , "br")]
[TestCase("b<r"  , "br")]
[TestCase("b>r"  , "br")]
[TestCase(@"b\r" , "br")]
[TestCase(@"b""r", "br")]
public void TestUrilizeNonAscii_NonValidCharactersForFragments(string input, string expectedResult)
{
    Assert.AreEqual(expectedResult, LinkHelper.Urilize(input, false));
}
Originally created by @Jither on GitHub (Jun 26, 2016). Tiny oversight in `LinkHelper.Urilize` - it throws out any and all digits. The easy fix: [LinkHelper.cs, Line 64 in current revision](https://github.com/lunet-io/markdig/blob/master/src/Markdig/Helpers/LinkHelper.cs#L64), insert: ``` csharp else if (c.IsDigit()) { headingBuffer.Append(c); previousIsSpace = false; } ``` And a few complimentary, non-exhaustive, tests. A few of them have a comment about not being equivalent to what Pandoc does (it doesn't trim trailing special chars). No-one says they have to be, though. :smiley: ``` csharp [TestCase("Header identifiers in HTML", "header-identifiers-in-html")] [TestCase("* Dogs*?--in *my* house?" , "dogs-in-my-house")] // Not Pandoc equivalent: dogs--in... [TestCase("[HTML], [S5], or [RTF]?" , "html-s5-or-rtf")] [TestCase("3. Applications" , "applications")] [TestCase("33" , "")] public void TestUrilizeNonAscii_Pandoc(string input, string expectedResult) { Assert.AreEqual(expectedResult, LinkHelper.Urilize(input, false)); } [TestCase("abc" , "abc")] [TestCase("a-c" , "a-c")] [TestCase("a c" , "a-c")] [TestCase("a_c" , "a_c")] [TestCase("a.c" , "a.c")] [TestCase("a,c" , "ac")] [TestCase("a--" , "a")] // Not Pandoc-equivalent: a-- [TestCase("a__" , "a")] // Not Pandoc-equivalent: a__ [TestCase("a.." , "a")] // Not Pandoc-equivalent: a.. [TestCase("a??" , "a")] [TestCase("a " , "a")] [TestCase("a--d", "a-d")] [TestCase("a__d", "a_d")] [TestCase("a??d", "ad")] [TestCase("a d", "a-d")] [TestCase("a..d", "a..d")] [TestCase("-bc" , "bc")] [TestCase("_bc" , "bc")] [TestCase(" bc" , "bc")] [TestCase("?bc" , "bc")] [TestCase(".bc" , "bc")] [TestCase("a-.-", "a")] // Not Pandoc equivalent: a-.- public void TestUrilizeOnlyAscii_Simple(string input, string expectedResult) { Assert.AreEqual(expectedResult, LinkHelper.Urilize(input, true)); } [TestCase("bær", "br")] [TestCase("bør", "br")] [TestCase("bΘr", "br")] [TestCase("四五", "")] public void TestUrilizeOnlyAscii_NonAscii(string input, string expectedResult) { Assert.AreEqual(expectedResult, LinkHelper.Urilize(input, true)); } [TestCase("bár" , "bar")] [TestCase("àrrivé", "arrive")] public void TestUrilizeOnlyAscii_Normalization(string input, string expectedResult) { Assert.AreEqual(expectedResult, LinkHelper.Urilize(input, true)); } [TestCase("123" , "")] [TestCase("1,-b" , "b")] [TestCase("b1,-" , "b1")] // Not Pandoc equivalent: b1- [TestCase("ab3" , "ab3")] [TestCase("ab3de", "ab3de")] public void TestUrilizeOnlyAscii_Numeric(string input, string expectedResult) { Assert.AreEqual(expectedResult, LinkHelper.Urilize(input, true)); } [TestCase("一二三四五", "一二三四五")] [TestCase("一,-b" , "一-b")] public void TestUrilizeNonAscii_NonAsciiNumeric(string input, string expectedResult) { Assert.AreEqual(expectedResult, LinkHelper.Urilize(input, false)); } [TestCase("bær" , "bær")] [TestCase("æ5el" , "æ5el")] [TestCase("-æ5el", "æ5el")] [TestCase("-frø-", "frø")] [TestCase("-fr-ø", "fr-ø")] public void TestUrilizeNonAscii_Simple(string input, string expectedResult) { Assert.AreEqual(expectedResult, LinkHelper.Urilize(input, false)); } // Just to be sure, test for characters expressly forbidden in URI fragments: [TestCase("b#r" , "br")] [TestCase("b%r" , "br")] // Invalid except as an escape character [TestCase("b^r" , "br")] [TestCase("b[r" , "br")] [TestCase("b]r" , "br")] [TestCase("b{r" , "br")] [TestCase("b}r" , "br")] [TestCase("b<r" , "br")] [TestCase("b>r" , "br")] [TestCase(@"b\r" , "br")] [TestCase(@"b""r", "br")] public void TestUrilizeNonAscii_NonValidCharactersForFragments(string input, string expectedResult) { Assert.AreEqual(expectedResult, LinkHelper.Urilize(input, false)); } ```
claunia added the bug label 2026-01-29 14:22:05 +00:00
claunia commented 2026-01-29 14:22:08 +00:00
Author
Owner
Copy Link

@xoofx commented on GitHub (Jun 26, 2016):

Good catch! Could you make a pull request for this? that helps to track things, thanks!

@xoofx commented on GitHub (Jun 26, 2016): Good catch! Could you make a pull request for this? that helps to track things, thanks!
claunia commented 2026-01-29 14:22:11 +00:00
Author
Owner
Copy Link

@Jither commented on GitHub (Jun 26, 2016):

Reluctantly, sure. 😆 Haven't used git for a few years, and back then, only on a non-team basis. Let's see how much I mess up...

ETA 9 days later: Enough to get blocked for 9 days.

@Jither commented on GitHub (Jun 26, 2016): Reluctantly, sure. :laughing: Haven't used git for a few years, and back then, only on a non-team basis. Let's see how much I mess up... ETA 9 days later: Enough to get blocked for 9 days.
claunia commented 2026-01-29 14:22:14 +00:00
Author
Owner
Copy Link

@xoofx commented on GitHub (Jul 5, 2016):

Fixed by commit 8f8b08fad6

@xoofx commented on GitHub (Jul 5, 2016): Fixed by commit 8f8b08fad6dc99978fb5ee28e1a261a3bdc09870
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
extension
Hacktoberfest
invalid
PR Welcome!
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#36
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?