Preferred way to implement extensions? (parser vs renderer manipulation) #360

New Issue

claunia · 2026-01-29T14:34:56Z

claunia commented

2026-01-29 14:34:56 +00:00

Originally created by @mlaily on GitHub (Apr 19, 2020).

First question:
What are the pros and cons of implementing extensions by manipulating the parser vs manipulating the renderer to obtain the same result? How to choose?

I have a specific case in mind: the SoftlineBreakAsHardlineExtension.

It's currently implemented by changing the parsing logic (using LineBreakInlineParser.EnableSoftAsHard), but it could also have been implemented by changing the renderer logic (using LineBreakInlineRenderer.RenderAsHardlineBreak)

Second question, that triggered the first one:
SoftlineBreakAsHardlineExtension does not cancel the parsing of hard line break constructs (double space or backslash at the end of a line). It's strange to see a backslash disappear for nothing when this extension is enabled...

Would a PR be welcome to add an option doing that? (and if so, should it be done in the parsers logic, or the renderers logic? and should it be on by default for this extension?)

Thanks for your time.

Originally created by @mlaily on GitHub (Apr 19, 2020). First question: What are the pros and cons of implementing extensions by manipulating the parser vs manipulating the renderer to obtain the same result? How to choose? I have a specific case in mind: the `SoftlineBreakAsHardlineExtension`. It's currently implemented by changing the parsing logic (using `LineBreakInlineParser.EnableSoftAsHard`), but it could also have been implemented by changing the renderer logic (using `LineBreakInlineRenderer.RenderAsHardlineBreak`) --- Second question, that triggered the first one: `SoftlineBreakAsHardlineExtension` does not cancel the parsing of hard line break constructs (double space or backslash at the end of a line). It's strange to see a backslash disappear for nothing when this extension is enabled... Would a PR be welcome to add an option doing that? (and if so, should it be done in the parsers logic, or the renderers logic? and should it be on by default for this extension?) Thanks for your time.

claunia referenced this issue

2026-01-29 14:47:57 +00:00

[PR #360] [MERGED] Fix SmartyPants quote matching #970

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/markdig#360