starred/markdig
1
0
Fork 0
mirror of https://github.com/xoofx/markdig.git synced 2026-02-04 05:44:50 +00:00
Code Issues 690 Packages Projects Releases 20 Wiki Activity

Setext headings in blockquotes #398

New Issue
Closed
opened 2026-01-29 14:35:46 +00:00 by claunia · 1 comment
claunia commented 2026-01-29 14:35:46 +00:00
Owner
Copy Link

Originally created by @hamvocke on GitHub (Aug 13, 2020).

There seems to be a problem with Setext headings used within blockquotes.

Take this markdown input:

> Hello
> ----
> this is some other text

Running this on babelmark shows that most renderers will generate a blockquote that contains a heading and a paragraph. Markdig, however, creates a blockquote that contains a paragraph, a horizontal rule and another paragraph.

The CommonMark spec is not absolutely explicit about this case but generally states that --- characters should be treated as a Setext heading if they can be interpreted that way.

Is this something that should be fixed in Markdig to be closer to what other Markdown renderers are doing?

Originally created by @hamvocke on GitHub (Aug 13, 2020). There seems to be a problem with [Setext headings](https://spec.commonmark.org/0.29/#setext-heading) used within blockquotes. Take this markdown input: ``` > Hello > ---- > this is some other text ``` Running this on [babelmark](https://babelmark.github.io/?text=%3E+Hello%0A%3E+----%0A%3E+this+is+some+other+text) shows that most renderers will generate a blockquote that contains a heading and a paragraph. Markdig, however, creates a blockquote that contains a paragraph, a horizontal rule and another paragraph. The CommonMark spec is not absolutely explicit about this case but [generally states](https://spec.commonmark.org/0.29/#example-29) that `---` characters should be treated as a Setext heading if they can be interpreted that way. Is this something that should be fixed in Markdig to be closer to what other Markdown renderers are doing?
claunia added the bugPR Welcome! labels 2026-01-29 14:35:46 +00:00
claunia commented 2026-01-29 14:35:48 +00:00
Author
Owner
Copy Link

@xoofx commented on GitHub (Aug 16, 2020):

It's definitely a bug, don't have time to look at this, but in case you have, PR welcome.

@xoofx commented on GitHub (Aug 16, 2020): It's definitely a bug, don't have time to look at this, but in case you have, PR welcome.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
extension
Hacktoberfest
invalid
PR Welcome!
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label bug PR Welcome!
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#398
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?