Consider passing mergeIdAndProperties as true in GenericAttributesParser #50

New Issue

claunia · 2026-01-29T14:23:14Z

claunia commented

2026-01-29 14:23:14 +00:00

Originally created by @christophano on GitHub (Aug 22, 2016).

Line 67 of GenericAttributesParser.cs calls the CopyTo method of the HtmlAttributes class.
It passes false as the MergeIdAndProperties argument, which means the existing Id is overwritten, even if there is no id on the instance itself.
If the argument is changed to true, then the Id property will only be overwritten if it has been set on the instance.

The scenario that I'm facing right now, is that I have an extension to automatically create Ids for definition term elements (based on their content) but, if I want to also apply a class using the Special Attributes extension, the id gets overwritten.

Originally created by @christophano on GitHub (Aug 22, 2016). Line 67 of `GenericAttributesParser.cs` calls the `CopyTo` method of the `HtmlAttributes` class. It passes false as the `MergeIdAndProperties` argument, which means the existing `Id` is overwritten, _even if there is no id on the instance itself_. If the argument is changed to true, then the `Id` property will only be overwritten if it has been set on the instance. The scenario that I'm facing right now, is that I have an extension to automatically create Ids for definition term elements (based on their content) but, if I want to also apply a class using the `Special Attributes` extension, the id gets overwritten.

claunia added the bug label 2026-01-29 14:23:14 +00:00

claunia closed this issue

2026-01-29 14:23:16 +00:00

claunia referenced this issue

2026-01-29 14:45:32 +00:00

[PR #50] [MERGED] Changes List Extra to output valid integer for start attribute, instead of roman or latin character. #788

claunia referenced this issue

2026-01-29 14:45:34 +00:00

[PR #50] Changes List Extra to output valid integer for start attribute, instead of roman or latin character. #793

Sign in to join this conversation.