mirror of
https://github.com/xoofx/markdig.git
synced 2026-02-10 14:00:05 +00:00
Globalization Extension is biased against English characters #524
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mhmd-azeez on GitHub (Apr 13, 2022).
Due to an optimization check, the extension ignores English characters entirely. So for this text:
expected: LTR
actual: RTL
And this case:
expected: RTL
actual: RTL
(This case above is correct, I just wrote it to make sure we don't mess it up when tying to fix the first one).
The fix is just to remove this check.
@MihaZupan commented on GitHub (Apr 13, 2022):
You're right, nice catch. Looks like I broke this in
c964659085.@mhmd-azeez commented on GitHub (Apr 13, 2022):
@MihaZupan no worries, it happens. I am surprised none of the tests broke though