starred/markdig
1
0
Fork 0
mirror of https://github.com/xoofx/markdig.git synced 2026-02-15 05:55:41 +00:00
Code Issues 690 Packages Projects Releases 21 Wiki Activity

MediaLinkExtensions: Controls #572

New Issue
Closed
opened 2026-01-29 14:40:04 +00:00 by claunia · 1 comment
claunia commented 2026-01-29 14:40:04 +00:00
Owner
Copy Link

Originally created by @LukeTOBrien on GitHub (Oct 13, 2022).

Hello,

I am creating a Static Website Generator and as one of my test I was creating a site with a video background, so this video has attributes muted, loop and autoplay but I do not want the controls attribute.
In MediaLinkExtension.cs line 113 there is code that adds the controls attribute but they is no way to say that I do not want this attribute to be added.
Do you think a boolean flag could be added to MediaOptions so that I can spefify that the attribute should not be added?

if (Options.Controls)
{
    htmlAttributes.AddPropertyIfNotExist("controls", null);
}

Thanks,

Luke

Originally created by @LukeTOBrien on GitHub (Oct 13, 2022). Hello, I am creating a Static Website Generator and as one of my test I was creating a site with a video background, so this video has attributes `muted`, `loop` and `autoplay` but I do not want the `controls` attribute. In [MediaLinkExtension.cs line 113](https://github.com/xoofx/markdig/blob/98c687b4ed8b7a7004837948fe18dcb8013528f7/src/Markdig/Extensions/MediaLinks/MediaLinkExtension.cs#L113) there is code that adds the `controls` attribute but they is no way to say that I do not want this attribute to be added. Do you think a boolean flag could be added to `MediaOptions` so that I can spefify that the attribute should not be added? ```cs if (Options.Controls) { htmlAttributes.AddPropertyIfNotExist("controls", null); } ``` Thanks, Luke
claunia added the enhancement label 2026-01-29 14:40:04 +00:00
claunia commented 2026-01-29 14:40:05 +00:00
Author
Owner
Copy Link

@xoofx commented on GitHub (Oct 13, 2022):

Do you think a boolean flag could be added to MediaOptions so that I can spefify that the attribute should not be added?

Yeah, completely, PR welcome.

@xoofx commented on GitHub (Oct 13, 2022): > Do you think a boolean flag could be added to MediaOptions so that I can spefify that the attribute should not be added? Yeah, completely, PR welcome.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
extension
Hacktoberfest
invalid
PR Welcome!
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#572
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?