starred/markdig
1
0
Fork 0
mirror of https://github.com/xoofx/markdig.git synced 2026-02-03 21:36:36 +00:00
Code Issues 690 Packages Projects Releases 20 Wiki Activity

Get LinkInline.Title of "" rather than null for [link](/uri) #742

New Issue
Closed
opened 2026-01-29 14:44:28 +00:00 by claunia · 1 comment
claunia commented 2026-01-29 14:44:28 +00:00
Owner
Copy Link

Originally created by @RamType0 on GitHub (May 10, 2025).

We get LinkInline.Title of "" with CommonMark Example 443.

[link](/uri)

As LinkInline.Title is typed as string? rather than string, it is weird.

3535701d70/src/Markdig/Renderers/Html/Inlines/LinkInlineRenderer.cs (L72-L77)

HtmlRenderer render correct result for [link](/uri) with current parse behavior, but it will generate incorrect result for [link](/uri "") instead.

Originally created by @RamType0 on GitHub (May 10, 2025). We get `LinkInline.Title` of `""` with [CommonMark Example 443](https://spec.commonmark.org/0.22/#example-443). > `[link](/uri)` As `LinkInline.Title` is typed as `string?` rather than `string`, it is weird. https://github.com/xoofx/markdig/blob/3535701d70066d055d06adaeaa1531b10601c6ac/src/Markdig/Renderers/Html/Inlines/LinkInlineRenderer.cs#L72-L77 `HtmlRenderer` render correct result for `[link](/uri)` with current parse behavior, but it will generate incorrect result for `[link](/uri "")` instead.
claunia added the bugPR Welcome! labels 2026-01-29 14:44:28 +00:00
claunia commented 2026-01-29 14:44:29 +00:00
Author
Owner
Copy Link

@Akarinnnnn commented on GitHub (May 31, 2025):

This line normalized nulls into empty string. Not sure will comment this out cause problems.
3535701d70/src/Markdig/Helpers/LinkHelper.cs (L414)

@Akarinnnnn commented on GitHub (May 31, 2025): This line normalized nulls into empty string. Not sure will comment this out cause problems. https://github.com/xoofx/markdig/blob/3535701d70066d055d06adaeaa1531b10601c6ac/src/Markdig/Helpers/LinkHelper.cs#L414
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
extension
Hacktoberfest
invalid
PR Welcome!
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label bug PR Welcome!
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/markdig#742
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?