[PR #24] [CLOSED] Update HtmlAttributes CopyTo logic #769

New Issue

claunia · 2026-01-29T14:45:19Z

claunia commented

2026-01-29 14:45:19 +00:00

📋 Pull Request Information

Original PR: https://github.com/xoofx/markdig/pull/24
Author: @billbogaiv
Created: 6/23/2016
Status: ❌ Closed

Base: master ← Head: update-htmlattributes-copyto-logic

📝 Commits (1)

1591215 Update HtmlAttributes CopyTo logic

📊 Changes

3 files changed (+40 additions, -2 deletions)

View changed files

📝 src/Markdig.Tests/Markdig.Tests.csproj (+1 -0)
➕ src/Markdig.Tests/Renderers/Html/HtmlAttributesTests.cs (+32 -0)
📝 src/Markdig/Renderers/Html/HtmlAttributes.cs (+7 -2)

📄 Description

New behavior does an additional check on the Classes and Properties properties to make sure null-values are not passed to their respective List constructors.
Previous behavior would throw an exception is the former was true and the share-parameter was false.

Ref. https://github.com/lunet-io/markdig/issues/23.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/xoofx/markdig/pull/24 **Author:** [@billbogaiv](https://github.com/billbogaiv) **Created:** 6/23/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `update-htmlattributes-copyto-logic` --- ### 📝 Commits (1) - [`1591215`](https://github.com/xoofx/markdig/commit/15912156caef5e7575af3c46b8fc941cd25e6c06) Update HtmlAttributes CopyTo logic ### 📊 Changes **3 files changed** (+40 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/Markdig.Tests/Markdig.Tests.csproj` (+1 -0) ➕ `src/Markdig.Tests/Renderers/Html/HtmlAttributesTests.cs` (+32 -0) 📝 `src/Markdig/Renderers/Html/HtmlAttributes.cs` (+7 -2) </details> ### 📄 Description New behavior does an additional check on the `Classes` and `Properties` properties to make sure null-values are not passed to their respective List<T> constructors. Previous behavior would throw an exception is the former was true and the `share`-parameter was `false`. Ref. https://github.com/lunet-io/markdig/issues/23. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 14:45:19 +00:00

claunia referenced this issue

2026-01-29 14:51:28 +00:00

[PR #769] [MERGED] Eliminate various string allocations #1213

claunia referenced this issue

2026-01-29 14:51:32 +00:00

[PR #769] Eliminate various string allocations #1218

Sign in to join this conversation.